Fix flaky e2e test TestProxyLoadBalancerModeDSR #6702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
tnqn
force-pushed
the
dsr-test
branch
2 times, most recently
from
159db08
to
6f228af
Compare
tnqn
changed the title
tnqn
added
area/test/e2e
antoninbas
previously approved these changes
Sep 30, 2024
| @@ -1184,7 +1193,7 @@ func TestProxyLoadBalancerModeDSR(t *testing.T) { | |||
| hostNames := sets.New[string]() | |||
| for i := 0; i < 10; i++ { | |||
| hostName := curlServiceWithPath(clientPod, clientNetns, "hostname") | |||
| t.Logf("Request #%d from %s got hostname: %s", i, clientPod, hostName) | |||
| t.Logf("[%s] Request #%d from %s got hostname: %s", time.Now().Format(microTimestampFormat), i, clientPod, hostName) | |||
There was a problem hiding this comment.
A comment here would be nice, in case someone updates this test in the future
We add a microsecond timestamp to the log message, which can be compared to the timestamp of the AntreaProxy messages in the Antrea Agent's logs. This is useful for troubleshooting test failures, in case there is a race condition with Service realization.
After creating or updating a Service, wait for 2 seconds before running traffic tests to ensure the Service is fully realized. Add a timestamp to help debug this test in the future. Signed-off-by: Quan Tian <[email protected]>
antoninbas
approved these changes
Oct 8, 2024
|
/test-e2e |
|
/test-e2e |
hangyan
pushed a commit
to hangyan/antrea
that referenced
this pull request
Oct 29, 2024
After creating or updating a Service, wait for 2 seconds before running traffic tests to ensure the Service is fully realized. Add a timestamp to help debug this test in the future. Signed-off-by: Quan Tian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After creating or updating a Service, wait for 2 seconds before running traffic tests to ensure the Service is fully realized.
Add a timestamp to help debug this test in the future.
Fixes #6704