Commits on Oct 15, 2024

1. Fix invalid conversion between unsafe.Pointer and uintptr …

   uintptr cannot be stored in variable before conversion back to Pointer.
   This is because the variable is an integer with no pointer semantics,
   even if a uintptr holds the address of some object, the garbage
   collector will not update that uintptr's value if the object moves, nor
   will that uintptr keep the object from being reclaimed.
   
   The issue can be detected by checkptr when running unit test with race
   detector:
   
   checkptr: pointer arithmetic result points to invalid allocation
   ```
   pFirstRow := uintptr(unsafe.Pointer(&table.Table[0]))
   row := *(*MibIPForwardRow)(unsafe.Pointer(pFirstRow + rowSize*uintptr(i)))
   ```
   
   While it can be fixed by performing both conversions in the same
   expression like below, using `unsafe.Slice` to get the slice is much
   simpler.
   ```
   row := *(*MibIPForwardRow)(unsafe.Pointer(uintptr(unsafe.Pointer(&table.Table[0])) + rowSize*uintptr(i)))
   ```
   
   The patch also adds an unit test to validate it.
   
   Signed-off-by: Quan Tian <[email protected]>

   

   tnqn committed Oct 15, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 9396532
   • Browse repository at this point

   Copy the full SHA

   9396532 View commit details

   Browse the repository at this point in the history