Clean up stale resources when 'antctl check cluster' failed #6597
Conversation
luolanzone
force-pushed
the
antctl-cleanup-temp-namespace
branch
from
5beaa37
to
e542c29
Compare
|
Checking on the antctl check installation e2e failure, convert this to a draft one. |
luolanzone
force-pushed
the
antctl-cleanup-temp-namespace
branch
2 times, most recently
from
aac6af7
to
fc915cd
Compare
| @@ -84,6 +88,7 @@ func (t *DenyAllConnectivityTest) Run(ctx context.Context, testContext *testCont | |||
| testContext.Log("NetworkPolicy deletion was successful") | |||
| return nil | |||
| }() | |||
| time.Sleep(networkPolicyDelay) | |||
There was a problem hiding this comment.
The *-deny-all e2e failures should have nothing to do with the changes for the stale resources cleanup, it's likely to be an issue with NP reconciliation which caused the service is connectable when deny is expected. So I added 2 seconds here to wait NP to be reconciled before the testing.
There was a problem hiding this comment.
I'd prefer something poll-based, but I guess this can be addressed in a later PR
There was a problem hiding this comment.
Sure, I can check later for poll-based with a new PR. Thanks.
| @@ -84,6 +88,7 @@ func (t *DenyAllConnectivityTest) Run(ctx context.Context, testContext *testCont | |||
| testContext.Log("NetworkPolicy deletion was successful") | |||
| return nil | |||
| }() | |||
| time.Sleep(networkPolicyDelay) | |||
There was a problem hiding this comment.
I'd prefer something poll-based, but I guess this can be addressed in a later PR
luolanzone
force-pushed
the
antctl-cleanup-temp-namespace
branch
from
fc915cd
to
e0cf413
Compare
Signed-off-by: Lan Luo <[email protected]>
luolanzone
force-pushed
the
antctl-cleanup-temp-namespace
branch
from
e0cf413
to
4787f28
Compare
|
/skip-all |
No description provided.