Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

antctl: unify checker image and make it configurable #6579

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Aug 1, 2024

To support scenarios that hardcoded images are not accessible.

Depends on antrea-io/image-utils#39

@tnqn tnqn added area/component/antctl Issues or PRs releated to the command line interface component action/release-note Indicates a PR that should be included in release notes. labels Aug 1, 2024
antoninbas
antoninbas previously approved these changes Aug 1, 2024
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

To support scenarios that hardcoded images are not accessible.

Signed-off-by: Quan Tian <[email protected]>
@tnqn
Copy link
Member Author

tnqn commented Aug 5, 2024

/skip-all

1 similar comment
@tnqn
Copy link
Member Author

tnqn commented Aug 5, 2024

/skip-all

@tnqn tnqn merged commit f48b61e into antrea-io:main Aug 5, 2024
53 of 58 checks passed
@tnqn tnqn deleted the improve-antctl-check-image branch August 5, 2024 02:59
@luolanzone luolanzone added kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release and removed kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release labels Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/release-note Indicates a PR that should be included in release notes. area/component/antctl Issues or PRs releated to the command line interface component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants