Make intermediate images share more common layers #5960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
previously approved these changes
Feb 5, 2024
| # Disable CGO for antctl in case it is copied outside of the container image. It | ||
| # also reduces the size of the binary and aligns with how we distribute antctl | ||
| # in release assets. | ||
| RUN --mount=type=cache,target=/go/pkg/mod/ \ | ||
| --mount=type=cache,target=/root/.cache/go-build/ \ | ||
| CGO_ENABLED=0 make antctl-linux && mv bin/antctl-linux bin/antctl | ||
|
|
||
| RUN --mount=type=cache,target=/go/pkg/mod/ \ |
There was a problem hiding this comment.
nit: a comment would be nice to explain that we build antrea-agent and antrea-cni first in order to share an extra layer with build/images/Dockerfile.build.agent.ubuntu
There was a problem hiding this comment.
done, also made same changes to coverage and ubi images.
By sharing more common layers, the total time can be reduced about 15s. Signed-off-by: Quan Tian <[email protected]>
antoninbas
approved these changes
Feb 6, 2024
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By sharing more common layers, the total time can be reduced about 15s.