Fix base-windows Dockerfile and script #4369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4369 +/- ##
==========================================
+ Coverage 63.34% 64.56% +1.22%
==========================================
Files 397 397
Lines 56204 56204
==========================================
+ Hits 35601 36287 +686
+ Misses 18011 17277 -734
- Partials 2592 2640 +48
|
tnqn
force-pushed
the
fix-base-windows-build
branch
from
388c056
to
8fc39eb
Compare
tnqn
changed the title
CNI_BINARIES_VERSION is missing when building windows-golang and antrea/base-windows images, leading to CNI binaries missing in the target image. The issue was not discovered because the curl command used in the Dockerfile ignored HTTP 404 code and didn't fail the build. The patch adds the missing argument and makes curl command fail on HTTP errors. Signed-off-by: Quan Tian <[email protected]>
tnqn
force-pushed
the
fix-base-windows-build
branch
from
8fc39eb
to
6e6cc34
Compare
XinShuYang
approved these changes
Nov 3, 2022
antoninbas
approved these changes
Nov 4, 2022
|
/skip-all |
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Jan 27, 2023
CNI_BINARIES_VERSION is missing when building windows-golang and antrea/base-windows images, leading to CNI binaries missing in the target image. The issue was not discovered because the curl command used in the Dockerfile ignored HTTP 404 code and didn't fail the build. The patch adds the missing argument and makes curl command fail on HTTP errors. Signed-off-by: Quan Tian <[email protected]>
heanlan
pushed a commit
to heanlan/antrea
that referenced
this pull request
Mar 29, 2023
CNI_BINARIES_VERSION is missing when building windows-golang and antrea/base-windows images, leading to CNI binaries missing in the target image. The issue was not discovered because the curl command used in the Dockerfile ignored HTTP 404 code and didn't fail the build. The patch adds the missing argument and makes curl command fail on HTTP errors. Signed-off-by: Quan Tian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNI_BINARIES_VERSION is missing when building windows-golang and base-windows images, leading to CNI binaries missing in the target image. The issue was not discovered because the curl command used in the Dockerfile ignored HTTP 404 code and didn't fail the build.
The patch adds the missing argument and makes curl command fail on HTTP errors.
Signed-off-by: Quan Tian [email protected]