-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor updates to the external Node document #4102
Conversation
I thought thoses sentences were some key points needed to remind users, that is why I emphasized them. I am OK if you think it is not necessary and remove the mark. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I actually got feedback from a reader that he felt he missed some important points after reading the sentences. And these two are actually about internal implementation, which users may not need to care. |
Codecov Report
@@ Coverage Diff @@
## feature/externalnode #4102 +/- ##
========================================================
+ Coverage 62.66% 65.65% +2.99%
========================================================
Files 299 302 +3
Lines 45991 46085 +94
========================================================
+ Hits 28819 30256 +1437
+ Misses 14819 13445 -1374
- Partials 2353 2384 +31
*This pull request uses carry forward flags. Click here to find out more.
|
Got it. I think the sentence about "L3 routing is not provided" is an internal implementation, but for the automatic convention from ExternalNode to ExternalEntity is actually what needs to be known by users, so that the users do not need to manually create ExternalEntity. |
Sure. But even that one seems to me need not to highlight in the whole doc. |
Signed-off-by: Jianjun Shen <[email protected]>
Signed-off-by: Jianjun Shen <[email protected]>
@wenyingd : when reading the doc, I feel these bold font sentences look strange, and also feel not necessary to emphasize them. Let me know what you think.