Update ClusterSet and ClusterClaim webhooks #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-multicluster-e2e |
hjiajing
reviewed
Jul 21, 2022
Codecov Report
@@ Coverage Diff @@
## main #4043 +/- ##
==========================================
+ Coverage 63.93% 65.40% +1.46%
==========================================
Files 292 307 +15
Lines 43671 43850 +179
==========================================
+ Hits 27922 28679 +757
+ Misses 13492 12843 -649
- Partials 2257 2328 +71
|
luolanzone
force-pushed
the
mc-webhooks
branch
2 times, most recently
from
4919ac2 to
e3bf763
Compare
|
/test-multicluster-e2e |
jianjuns
reviewed
Jul 22, 2022
| if r.Name != WellKnownClusterClaimClusterSet && r.Name != WellKnownClusterClaimID { | ||
| err := fmt.Errorf("The name %s is not valid, only 'id.k8s.io' and 'clusterset.k8s.io' are valid names for ClusterClaim", r.Name) | ||
| err := fmt.Errorf("the name %s is not valid, only 'id.k8s.io' and 'clusterset.k8s.io' are valid names for ClusterClaim", r.Name) |
| } | ||
|
|
||
| if len(clusterSetList.Items) > 0 { | ||
| klog.ErrorS(fmt.Errorf("multiple ClusterSets in the Namespace are not allowed"), |
There was a problem hiding this comment.
Why not create a single error to be used both here and in the returned error?
There was a problem hiding this comment.
"multiple ClusterSets in a Namespace are not allowed" or "only a single ClusterSet is allowed in a Namespace"
There was a problem hiding this comment.
Done. defined an error "multiple ClusterSets in a Namespace are not allowed"
1. Add a ClusterSet webhook to make Leader's `clusterID` immutable, and allow only one ClusterSet in mc-controller's Namespace. 2. Update ClusterClaim webhook to make `value` field (ClusterID/ClusterSetID) immutable 3. Remove unused mutate webhook of ClusterClaim Signed-off-by: Lan Luo <[email protected]>
jianjuns
approved these changes
Jul 25, 2022
|
/test-multicluster-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow only one ClusterSet in mc-controller's Namespace.
Valuefield(ClusterID/ClusterSetID) immutable
Signed-off-by: Lan Luo [email protected]