Add antctl commands to set up and delete Multi-cluster ClusterSet #3992

hjiajing · 2022-07-12T05:33:51Z

Add 4 new commands for the users to set up and delete ClusterSets. And
delete some old commands.

antctl mc init: to set up a ClusterSet in a leader cluster.
antctl mc join: to join a ClusterSet in a member cluster.
antctl mc destroy: to delete a ClusterSet in a leader cluster.
antctl mc leave: to leave a ClusterSet in a member cluster.

codecov · 2022-07-12T05:41:14Z

Codecov Report

Merging #3992 (0c7a042) into main (2bf6a9a) will increase coverage by 7.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3992      +/-   ##
==========================================
+ Coverage   61.19%   68.31%   +7.11%     
==========================================
  Files         294      310      +16     
  Lines       44262    45539    +1277     
==========================================
+ Hits        27088    31109    +4021     
+ Misses      14885    12015    -2870     
- Partials     2289     2415     +126

Flag	Coverage Δ
e2e-tests	`41.74% <100.00%> (?)`
integration-tests	`35.37% <100.00%> (?)`
kind-e2e-tests	`50.57% <ø> (+6.41%)`	⬆️
unit-tests	`44.25% <0.00%> (+0.03%)`	⬆️

Impacted Files	Coverage Δ
pkg/antctl/antctl.go	`50.00% <ø> (ø)`
...lers/multicluster/commonarea/remote_common_area.go	`73.06% <100.00%> (+45.30%)`	⬆️
pkg/agent/flowexporter/exporter/certificate.go	`27.77% <0.00%> (-22.23%)`	⬇️
...agent/flowexporter/connections/deny_connections.go	`65.59% <0.00%> (-13.98%)`	⬇️
...kg/controller/networkpolicy/antreanetworkpolicy.go	`74.75% <0.00%> (-12.43%)`	⬇️
pkg/controller/networkpolicy/status_controller.go	`65.10% <0.00%> (-3.45%)`	⬇️
pkg/ovs/openflow/ofctrl_packetin.go	`66.66% <0.00%> (-2.96%)`	⬇️
...ntroller/networkpolicy/networkpolicy_controller.go	`79.43% <0.00%> (-2.90%)`	⬇️
pkg/controller/ipam/antrea_ipam_controller.go	`76.25% <0.00%> (-2.79%)`	⬇️
pkg/controller/externalippool/controller.go	`83.03% <0.00%> (-1.79%)`	⬇️
... and 128 more

pkg/antctl/raw/multicluster/join/join.go

luolanzone · 2022-07-13T07:29:48Z

pkg/antctl/raw/multicluster/join/join.go

+				--namespace=<NAMESPACE> \
+				--cluster-id=<MEMBER_CLUSTER_ID>
+
+# Join the ClusterSet from a member cluster with config file. If you use both command line options and config file, 


Please update the doc for antctl as well.

Sure. I'll update the doc for antctl after finishing the commands JIanjun mentioned in another comment.

pkg/antctl/raw/multicluster/join/join.go

luolanzone · 2022-07-13T08:22:23Z

pkg/antctl/raw/multicluster/join/join.go

+func waitForLeaderClusterSetReady(client client.Client, name string, namespace string, memberClusterID string) error {
+	return wait.PollImmediate(
+		1*time.Second,
+		3*time.Minute,


Is this too long?

Maybe we can add a timeout argument? I test on my PC sometimes it just takes several seconds, sometimes more than 1 mins.

pkg/antctl/raw/multicluster/join/join.go

luolanzone · 2022-07-14T08:04:00Z

@hjiajing Could you update the PR summary to link it with issue #3921. You can refer to the link here to understand how to link them.

hjiajing · 2022-07-14T08:06:43Z

@luolanzone Sure. Thanks for reminding me.

lgtm-com · 2022-07-15T07:49:03Z

This pull request introduces 2 alerts when merging 90b874a into 4b788e7 - view on LGTM.com

new alerts:

2 for Unreachable statement

jianjuns · 2022-07-16T03:29:06Z

pkg/antctl/raw/multicluster/commands.go

@@ -49,6 +50,8 @@ var DeployCmd = &cobra.Command{
 	Short: "Deploy Antrea Multi-cluster Controller to a leader or member cluster",
 }

+var JoinCmd = join.NewJoinCommand()


Besides join for member clusters, would you add a command for the leader or change "create clusterset" too? Pasted below what we discussed in #3921 :

So, we just need two commands:

"deploy" to deploy MC controllers;

"create clusterset" (or "init" in leader and "join" in member as kubeadmin) to create/join a clusterset. For the leader, the command can generate a shared SA/token for member to join the clusterset.

I meant we either:

change the current "create clusterset" command to create a clusterset & a default SA/taken in the leader; and create a clusterset & join it in a member

or, add an "init" command to create a clusterset & a default SA/taken in the leader; and a "join" command to create a clusterset & join it in a member

But if we go 2), how should a leader/member leave a ClsuterSet? Would you add anther "destroy" command for leader and a "leave" command for member?

In any case, we should remove the commands that are no longer valid, like "create claims", "add member", etc.

Sure. I will add those commands. thanks for advice.

Could you talk about your design choices (what commands to add or revise) too? We do not have much time for 1.8.0, and need to be more productive on design/discussions.

Design added in #3921

pkg/antctl/raw/multicluster/join/join.go

pkg/antctl/raw/multicluster/create/access_token.go

pkg/antctl/raw/multicluster/destroy.go

pkg/antctl/raw/multicluster/join.go

pkg/antctl/raw/multicluster/leave.go

jianjuns · 2022-07-27T20:32:21Z

@hjiajing : please wrap lines in commit message at column 72.

jianjuns · 2022-08-09T04:41:42Z

docs/multicluster/antctl.md

-+ `antctl mc create clusterclaims` command can create two ClusterClaims in a leader or member cluster. One for the leader or member cluster, and another for the ClusterSet.
-+ `antctl mc create clusterset` command can create a ClusterSet in a leader or member cluster.
+`antctl mc create` command can create tokens for member clusters to join a ClusterSet. The command will
+also create a Secret to store the token, as well as a ServiceAccount and a RoleBinding. The --output-file


Add `` around --output-file

jianjuns · 2022-08-09T04:45:36Z

docs/multicluster/antctl.md

-+ `antctl mc delete clusterset` command can delete a ClusterSet in a leader or member cluster.
-+ `antctl mc delete member-cluster` command can delete a member cluster in a specified Antrea Multi-cluster ClusterSet.
+`antctl mc init` command initializes an Antrea Multi-cluster ClusterSet in a leader cluster. It will create a
+ClusterSet and ClusterClaims for the leader cluster. If the `--output-file` option is set, the join config


Humm.. I feel we still need to rephrase the sentence. How about:

", the config arguments for member clusters to join the ClusterSet will be saved to the specified file."

Also change "set" to "specified"

pkg/antctl/raw/multicluster/join.go

docs/multicluster/antctl.md

pkg/antctl/raw/multicluster/join.go

jianjuns · 2022-08-09T05:01:36Z

pkg/antctl/raw/multicluster/join.go

+	command.Flags().StringVarP(&joinOpts.LeaderNamespace, "leader-namespace", "", "", "Namespace of the leader cluster")
+	command.Flags().StringVarP(&joinOpts.LeaderClusterID, "leader-clusterid", "", "", "Cluster ID of the leader cluster")
+	command.Flags().StringVarP(&joinOpts.TokenSecretName, "token-secret-name", "", "", "Name of the Secret resource that contains the member token. "+
+		"Token Secret name takes precedence over token Secret file and Secret manifest in the join config file")


"and the Secret manifest"

Added "and"

jianjuns · 2022-08-09T05:04:33Z

pkg/antctl/raw/multicluster/join.go

+		}
+	}
+
+	// The precedence order is that the TokenSecretName > TokenSecretFile > JoinConfigFile.


Nit: remove "the".

jianjuns · 2022-08-09T05:08:28Z

pkg/antctl/raw/multicluster/common/cleanup.go

+	}
+	err = deleteClusterClaims(cmd, k8sClient, cleanOpts.Namespace)
+	if err != nil {
+		fmt.Fprintf(cmd.OutOrStdout(), "Failed to delete ClusterClaim: %v\n", err)


First, we should remove the logs. Otherwise, we got duplicated log messages.

I meant just to remove "err =", so we have:

deleteClusterClaims(cmd, k8sClient, cleanOpts.Namespace) deleteClusterSet(cmd, k8sClient, cleanOpts.Namespace, cleanOpts.ClusterSet) ...

Will this really get an error of golang checking? What is the error?

luolanzone · 2022-08-09T06:23:31Z

docs/multicluster/antctl.md


-+ `antctl mc deploy leadercluster` command can deploy Antrea Multi-cluster Controller to a leader cluster, and define all the CRDs the leader cluster needed.
-+ `antctl mc deploy membercluster` command can deploy Antrea Multi-cluster Controller to a member cluster, and define all the CRDs the member cluster needed.
+When the config file is provided, the command line options may be overridden by the file. A token is needed for a


Suggested change

When the config file is provided, the command line options may be overridden by the file. A token is needed for a

When the config file is provided, the command line options may be overwritten by the file. A token is needed for a

luolanzone · 2022-08-09T06:27:04Z

docs/multicluster/antctl.md

+
+## antctl mc leave
+
+`antctl mc leave` command lets a member cluster leave a ClusterSet. It will delete  the ClusterSet and ClusterClaims


Suggested change

`antctl mc leave` command lets a member cluster leave a ClusterSet. It will delete the ClusterSet and ClusterClaims

`antctl mc leave` command lets a member cluster leave a ClusterSet. It will delete the ClusterSet and ClusterClaims

luolanzone · 2022-08-09T06:31:47Z

pkg/antctl/raw/multicluster/common/cleanup.go

+	deleteClusterClaims(cmd, k8sClient, cleanOpts.Namespace)
+	deleteClusterSet(cmd, k8sClient, cleanOpts.Namespace, cleanOpts.ClusterSet)


Could you delete ClusterSet first, them ClusterClaim? Here is a on-going PR #4062 which will stop ClusterClaim deletion if there is any ClusterSet referring to it.

Sure. Fixed.

luolanzone · 2022-08-09T06:34:42Z

pkg/antctl/raw/multicluster/common/common.go

+	return e
+}
+
+func deleteClusterSet(cmd *cobra.Command, k8sClient client.Client, namespace string, clusterSet string) error {


I didn't see you catch the error by deleteClusterSet and other delete methods on cleanup, so the return error can be removed?

luolanzone · 2022-08-09T07:01:05Z

pkg/antctl/raw/multicluster/join.go

+		return fmt.Errorf("a member token Secret must be provided through the Secret Name, or Secret file, or Secret manifest in the config file")
+	}
+	if o.LeaderNamespace == "" {
+		return fmt.Errorf("the the leader cluster Namespace is required")


Suggested change

return fmt.Errorf("the the leader cluster Namespace is required")

return fmt.Errorf("the leader cluster Namespace is required")

luolanzone · 2022-08-09T07:07:50Z

pkg/antctl/raw/multicluster/join.go

+		return fmt.Errorf("the API server of the leader cluster is required")
+	}
+	if o.TokenSecretName == "" && o.Secret == nil {
+		return fmt.Errorf("a member token Secret must be provided through the Secret Name, or Secret file, or Secret manifest in the config file")


Suggested change

return fmt.Errorf("a member token Secret must be provided through the Secret Name, or Secret file, or Secret manifest in the config file")

return fmt.Errorf("a member token Secret must be provided through the Secret name, or Secret file, or Secret manifest in the config file")

pkg/antctl/raw/multicluster/join.go

luolanzone · 2022-08-09T07:20:16Z

pkg/antctl/raw/multicluster/leave.go

+var leaveOpts *common.CleanOptions
+
+var leaveExamples = strings.Trim(`
+# Leave the ClusterSet.


Suggested change

# Leave the ClusterSet.

# Leave the ClusterSet from a member cluster.

luolanzone · 2022-08-09T07:21:45Z

pkg/antctl/raw/multicluster/leave.go

+func NewLeaveCommand() *cobra.Command {
+	command := &cobra.Command{
+		Use:     "leave",
+		Short:   "Leave ClusterSet from a member cluster",


Suggested change

Short: "Leave ClusterSet from a member cluster",

Short: "Leave the ClusterSet from a member cluster",

jianjuns

LGTM

jianjuns · 2022-08-09T19:11:30Z

pkg/antctl/raw/multicluster/common/common.go

+	if err != nil {
+		return err
+	}
+	if _, err := file.Write([]byte("\n# Create a token Secret with the embedded manifest.\n")); err != nil {


I feel this line is not necessary as it looks strange in the standalone token Secret YAML file (not the join-config YAML). But not a big deal.

If we want to keep it, maybe rephrase the comment to be more generic, like

"# Manifest to create a Secret for a member cluster token."

Changed the comment to " Manifest to create a Secret for a member cluster token."

jianjuns · 2022-08-09T23:24:23Z

docs/multicluster/antctl.md


 ```bash
-antctl mc add membercluster [CLUSTER_ID] [-n NAMESPACE] [--clusterset CLUSTERSET] [--service-account SERVICE_ACCOUNT]
+antctl mc deploy leadercluster [--antrea-version ANTREA_VERSION] [-n NAMESPACE] [-f PATH_TO_MANIFEST]


Should we use:

antctl mc deploy leadercluster -n NAMESPACE [--antrea-version ANTREA_VERSION] [-f PATH_TO_MANIFEST]

assuming Namespace is mandatory?

jianjuns · 2022-08-09T23:25:05Z

docs/multicluster/antctl.md

-antctl mc delete clusterclaims [-n NAMESPACE]
-antctl mc delete clusterset [NAME] [-n NAMESPACE]
-antctl mc delete membercluster [MEMBER_CLUSTER_ID] [-n NAMESPACE] [--clusterset CLUSTERSET]
+antctl mc init [-n NAMESPACE] [--clusterset CLUSTERSET_ID] [--clusterid CLUSTERID] [--create-token] [--output-file OUTPUT_FILE]


Should we use:

antctl mc init -n NAMESPACE --clusterset CLUSTERSET_ID --clusterid CLUSTERID [--create-token] [--output-file OUTPUT_FILE]

jianjuns · 2022-08-09T23:25:50Z

docs/multicluster/antctl.md


 ```bash
-antctl mc deploy leadercluster [--antrea-version ANTREA_VERSION] [-n NAMESPACE] [-f PATH_TO_MANIFEST]
-antctl mc deploy membercluster [--antrea-version ANTREA_VERSION] [-n NAMESPACE] [-f PATH_TO_MANIFEST]
+antctl mc join --clusterset=[CLUSTERSET_ID] \


Should we remove "[]" around the values? "[]" usually means optional.

Sure. Removed the "[]".

jianjuns · 2022-08-09T23:26:47Z

docs/multicluster/antctl.md

+and other resources created by antctl for the member cluster.
+
+```bash
+antctl mc leave --clusterset=[CLUSTERSET_ID] --namespace [NAMESPACE]


antctl mc leave --clusterset=CLUSTERSET_ID [--namespace NAMESPACE]

?

docs/multicluster/antctl.md

jianjuns · 2022-08-10T01:34:36Z

docs/multicluster/antctl.md

+ClusterSet and ClusterClaims and other resources created by antctl for the leader cluster.
+
+```bash
+antctl mc destroy --clusterset=CLUSTERSET_ID --namespace [NAMESPACE]


Namespace is not optional for "destroy".

Removed the "[]"

jianjuns · 2022-08-10T01:35:33Z

docs/multicluster/antctl.md

-antctl mc deploy membercluster [--antrea-version ANTREA_VERSION] [-n NAMESPACE] [-f PATH_TO_MANIFEST]
+antctl mc join --clusterset=CLUSTERSET_ID \
+                   --clusterid=CLUSTER_ID \
+                   --namespace=MEMBER_NAMESPACE \


We can change to [--namespace=MEMBER_NAMESPACE]

jianjuns · 2022-08-10T01:35:51Z

docs/multicluster/antctl.md

+                   --leader-clusterid=LEADER_CLUSTER_ID \
+                   --leader-namespace=LEADER_NAMESPACE \
+                   --leader-apiserver=LEADER_APISERVER \
+                   --token-secret-name=TOKEN_SECRET_NAME \


jianjuns · 2022-08-10T01:35:56Z

docs/multicluster/antctl.md

+                   --leader-namespace=LEADER_NAMESPACE \
+                   --leader-apiserver=LEADER_APISERVER \
+                   --token-secret-name=TOKEN_SECRET_NAME \
+                   --token-secret-file=TOKEN_SECRET_FILE


jianjuns · 2022-08-10T01:37:29Z

docs/multicluster/antctl.md

+                   --token-secret-name=TOKEN_SECRET_NAME \
+                   --token-secret-file=TOKEN_SECRET_FILE
+
+antctl mc join --config-file PATH_TO_CONFIG_FILE


Maybe we can add [--clusterid=CLUSTER_ID] [--token-secret-name=TOKEN_SECRET_NAME] [--token-secret-file=TOKEN_SECRET_FILE] to indicate these can be overwritten?

Added the optional arguments.

jianjuns · 2022-08-10T01:39:00Z

docs/multicluster/antctl.md

-anctcl mc create accesstoken [NAME] [-n NAMESPACE] [--serviceaccount SERVICE_ACCOUNT] [--role-binding ROLE_BINDING]
-antctl mc create clusterclaims [-n NAMESPACE] [--clusterset-id CLUSTERSET_ID] [--cluster-id CLUSTER_ID]
-antctl mc create clusterset [NAME] [-n NAMESPACE] [--leader-server LEADER_SERVER] [--service-account SERVICE_ACCOUNT] [--secret SECRET] [--leader-cluster LEADER_CLUSTER_ID]
+anctcl mc create membertoken NAME -n NAMESPACE [--output-file OUTPUT_FILE]


Consider using "-o".

Change to -o.

docs/multicluster/antctl.md

jianjuns · 2022-08-10T04:51:17Z

pkg/antctl/raw/multicluster/init.go

+	config := &ClusterSetJoinConfig{
+		APIVersion:      common.ClusterSetJoinConfigAPIVersion,
+		Kind:            common.ClusterSetJoinConfigKind,
+		Namespace:       "",


@hjiajing : when we unmarshal the YAML, will these "" fields overwrite values in ClusterSetJoinConfig?

If so, I suggest not to set these fields in the generated file, as I hope the join command can use command line options to provide these arguments which seems the most convenient way for users.

I meant something like antctl mc join --clusterid test-cluster-leader -n kube-system --config-file join-config.yml

Or even better, if we can write clusterID and namespace and other optional fields to the config file as comments:

#clusterID: "" #namespace: "" # Use the pre-created token Secret. #tokenSecretName: "" # Create a token Secret with the manifest file. #toeknSecretFile: ""

See also the discussion at #4096 (comment).

Added a raw string constant now the output join config looks like

--- kind: ClusterSetJoinConfig apiVersion: multicluster.antrea.io/v1alpha1 clusterSetID: test-clusterset leaderClusterID: test-cluster-north leaderNamespace: antrea-multicluster leaderAPIServer: https://172.18.0.3:6443 clusterID: "test-cluster-east" #namespace: "" # Use the pre-created token Secret. #tokenSecretName: "" # Create a token Secret with the manifest file. #toeknSecretFile: ""

I feel we should comment out clusterID too, so it can be overwritten by command line argument.

#clusterID: ""

Sorry I copied the output file which I edited. The output is

"config.yaml" 25L, 3372B 13,1 All --- kind: ClusterSetJoinConfig apiVersion: multicluster.antrea.io/v1alpha1 clusterSetID: test-clusterset leaderClusterID: test-cluster-north leaderNamespace: antrea-multicluster leaderAPIServer: https://172.18.0.3:6443 #clusterID: "" #namespace: "" # Use the pre-created token Secret. #tokenSecretName: "" # Create a token Secret with the manifest file. #toeknSecretFile: ""

The clusterID is commented out.

pkg/antctl/raw/multicluster/common/common.go

jianjuns · 2022-08-10T17:42:44Z

pkg/antctl/raw/multicluster/join.go

+func unmarshallSecret(raw []byte) (*v1.Secret, error) {
+	decoder := yamlutil.NewYAMLOrJSONDecoder(bytes.NewReader(raw), 100)
+	secret := &v1.Secret{}
+	// We need to skip the first object in the config file which is ClusterSetJoinConfig


Question - why we need to do the same for Secret file? Maybe we need to revise the comment?

The output of Secret and join config both start with ---. So when we unmarshall the Secret, we need to skip the first object, too. Revised the comment now.

jianjuns · 2022-08-10T18:08:48Z

pkg/antctl/raw/multicluster/join.go

+func unmarshallSecret(raw []byte) (*v1.Secret, error) {
+	decoder := yamlutil.NewYAMLOrJSONDecoder(bytes.NewReader(raw), 100)
+	secret := &v1.Secret{}
+	// We need to skip the first object, the Secret object is always the second object when unmarshalling the


, as the Secret object...

Signed-off-by: hujiajing <[email protected]>

jianjuns · 2022-08-10T18:22:18Z

@hjiajing Thanks for the hard work and addressing all comments!

jianjuns · 2022-08-10T19:27:05Z

/test-e2e
/test-multicluster-e2e

jianjuns · 2022-08-10T20:21:31Z

/test-integration

jianjuns · 2022-08-10T21:26:12Z

/skip-all

hjiajing requested review from luolanzone and jianjuns July 12, 2022 05:33

hjiajing force-pushed the antctl-join branch from e47b733 to 53125b0 Compare July 12, 2022 07:07

luolanzone added the area/multi-cluster Issues or PRs related to multi cluster. label Jul 13, 2022

luolanzone added this to the Antrea v1.8 release milestone Jul 13, 2022

luolanzone reviewed Jul 13, 2022

View reviewed changes

hjiajing linked an issue Jul 14, 2022 that may be closed by this pull request

Multi-cluster antctl command refactor #3921

Closed

hjiajing force-pushed the antctl-join branch from 53125b0 to 90b874a Compare July 15, 2022 07:13

jianjuns changed the title ~~Add antctl join command for member cluster to join the ClusterSet~~ Add antctl join command for member cluster to join ClusterSet Jul 16, 2022

jianjuns reviewed Jul 16, 2022

View reviewed changes

hjiajing force-pushed the antctl-join branch 2 times, most recently from 5fef660 to 206a7a1 Compare July 19, 2022 06:01

hjiajing force-pushed the antctl-join branch from 206a7a1 to 59c7e51 Compare July 26, 2022 14:33

jianjuns reviewed Jul 27, 2022

View reviewed changes

hjiajing force-pushed the antctl-join branch 11 times, most recently from cd8d492 to 46a644f Compare July 28, 2022 15:37

hjiajing force-pushed the antctl-join branch 2 times, most recently from 1c983ea to 99bee47 Compare August 9, 2022 02:07

jianjuns reviewed Aug 9, 2022

View reviewed changes

hjiajing force-pushed the antctl-join branch from 99bee47 to c5c5394 Compare August 9, 2022 05:48

luolanzone reviewed Aug 9, 2022

View reviewed changes

hjiajing force-pushed the antctl-join branch from c5c5394 to 59bcfb1 Compare August 9, 2022 08:22

jianjuns reviewed Aug 9, 2022

View reviewed changes

docs/multicluster/antctl.md Outdated Show resolved Hide resolved

hjiajing force-pushed the antctl-join branch from 59bcfb1 to 8efa04a Compare August 10, 2022 01:32

jianjuns reviewed Aug 10, 2022

View reviewed changes

hjiajing force-pushed the antctl-join branch from 8efa04a to 9180687 Compare August 10, 2022 01:43

jianjuns previously approved these changes Aug 10, 2022

View reviewed changes

jianjuns reviewed Aug 10, 2022

View reviewed changes

luolanzone reviewed Aug 10, 2022

View reviewed changes

pkg/antctl/raw/multicluster/common/common.go Outdated Show resolved Hide resolved

hjiajing dismissed jianjuns’s stale review via de8f1ad August 10, 2022 08:23

hjiajing force-pushed the antctl-join branch 2 times, most recently from de8f1ad to 068a3c5 Compare August 10, 2022 17:33

jianjuns reviewed Aug 10, 2022

View reviewed changes

hjiajing force-pushed the antctl-join branch from 068a3c5 to fca347b Compare August 10, 2022 18:00

jianjuns reviewed Aug 10, 2022

View reviewed changes

Add antctl join command

0c7a042

Signed-off-by: hujiajing <[email protected]>

hjiajing force-pushed the antctl-join branch from fca347b to 0c7a042 Compare August 10, 2022 18:20

jianjuns approved these changes Aug 10, 2022

View reviewed changes

jianjuns merged commit 04b9dc6 into antrea-io:main Aug 10, 2022

	When the config file is provided, the command line options may be overridden by the file. A token is needed for a
	When the config file is provided, the command line options may be overwritten by the file. A token is needed for a


		## antctl mc leave

		`antctl mc leave` command lets a member cluster leave a ClusterSet. It will delete the ClusterSet and ClusterClaims

		deleteClusterClaims(cmd, k8sClient, cleanOpts.Namespace)
		deleteClusterSet(cmd, k8sClient, cleanOpts.Namespace, cleanOpts.ClusterSet)

	return fmt.Errorf("the the leader cluster Namespace is required")
	return fmt.Errorf("the leader cluster Namespace is required")

	return fmt.Errorf("a member token Secret must be provided through the Secret Name, or Secret file, or Secret manifest in the config file")
	return fmt.Errorf("a member token Secret must be provided through the Secret name, or Secret file, or Secret manifest in the config file")

	# Leave the ClusterSet.
	# Leave the ClusterSet from a member cluster.

	Short: "Leave ClusterSet from a member cluster",
	Short: "Leave the ClusterSet from a member cluster",

Add antctl commands to set up and delete Multi-cluster ClusterSet #3992

Add antctl commands to set up and delete Multi-cluster ClusterSet #3992

Conversation

hjiajing commented Jul 12, 2022 • edited by jianjuns Loading

codecov bot commented Jul 12, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luolanzone commented Jul 14, 2022

hjiajing commented Jul 14, 2022

lgtm-com bot commented Jul 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jianjuns commented Jul 27, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jianjuns left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jianjuns commented Aug 10, 2022

jianjuns commented Aug 10, 2022

jianjuns commented Aug 10, 2022

jianjuns commented Aug 10, 2022

hjiajing commented Jul 12, 2022 •

edited by jianjuns

Loading

codecov bot commented Jul 12, 2022 •

edited

Loading