[Multicast] support encap mode #3947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyingd
force-pushed
the
multicast_encap
branch
2 times, most recently
from
5ac8704 to
aa4797a
Compare
Codecov Report
@@ Coverage Diff @@
## main #3947 +/- ##
==========================================
+ Coverage 63.93% 64.56% +0.62%
==========================================
Files 292 296 +4
Lines 43671 44964 +1293
==========================================
+ Hits 27922 29029 +1107
- Misses 13492 13649 +157
- Partials 2257 2286 +29
*This pull request uses carry forward flags. Click here to find out more.
|
wenyingd
force-pushed
the
multicast_encap
branch
4 times, most recently
from
5d3fd03 to
4341561
Compare
|
/test-multicast-e2e |
liu4480
reviewed
Jul 4, 2022
| eType eventType | ||
| time time.Time | ||
| iface *interfacestore.InterfaceConfig | ||
| sender net.IP |
There was a problem hiding this comment.
does sender mean a sender in multicast group? what if there are multiple senders?
There was a problem hiding this comment.
No it means the source Node who sends IGMP report. I rename it as "srcNode". It is used only with encap mode.
liu4480
reviewed
Jul 4, 2022
ceclinux
reviewed
Jul 5, 2022
ceclinux
reviewed
Jul 5, 2022
ceclinux
reviewed
Jul 5, 2022
ceclinux
reviewed
Jul 5, 2022
wenyingd
force-pushed
the
multicast_encap
branch
6 times, most recently
from
8af2d87 to
c5e37e7
Compare
|
/test-all |
|
/test-e2e |
tnqn
reviewed
Jul 12, 2022
wenyingd
force-pushed
the
multicast_encap
branch
3 times, most recently
from
f20e550 to
9d66c05
Compare
tnqn
reviewed
Jul 19, 2022
wenyingd
force-pushed
the
multicast_encap
branch
4 times, most recently
from
60de85e to
70ade2b
Compare
|
/test-all |
tnqn
reviewed
Jul 21, 2022
wenyingd
force-pushed
the
multicast_encap
branch
from
70ade2b to
5106617
Compare
|
/test-all |
wenyingd
force-pushed
the
multicast_encap
branch
from
5106617 to
cc4dbbe
Compare
|
/test-all |
wenyingd
force-pushed
the
multicast_encap
branch
from
cc4dbbe to
de86ae4
Compare
|
/test-all |
|
/test-multicast-e2e |
1 similar comment
|
/test-multicast-e2e |
|
/test-e2e |
tnqn
reviewed
Jul 26, 2022
test/e2e/multicast_test.go
Outdated
| func runTestMulticastBetweenPods(t *testing.T, data *TestData, mc multicastTestcase, nodeMulticastInterfaces map[int][]string, checkReceiverRoute bool) { | ||
| currentEncapMode, _ := data.GetEncapMode() | ||
| if requiresExternalHostSupport(mc) && currentEncapMode == config.TrafficEncapModeEncap { | ||
| t.Logf("Multicast does not support using hostNetwork Pod to simulate the external host with encap mode, skip the case") |
There was a problem hiding this comment.
Use t.Skip, then the subtest will be marked as "Skip" instead of "Pass"
1, Use a single routine to send local multicast groups in an IGMP v3
Report message to notify all the other Nodes in the cluster
2. Multicast controller maintains both local Pod members and remote
Nodes which has Pod members for each multicast group found in the
cluster
3. Add remote Node members in the OpenFlow group buckets.
4. Agent drops the duplicated multicast packet received from underlay by
- adding iptables rules in raw table antreaPreRouting chain to drop
multicast packets sent from other Nodes, because the Pod multicast
traffic is received from tunnel with encap mode.
- adding an ipset to maintain IPs of other Nodes in the cluster, which
is used as source in the iptables rule.
Signed-off-by: wenyingd <[email protected]>
wenyingd
force-pushed
the
multicast_encap
branch
from
de86ae4 to
f77042b
Compare
|
/test-all |
hjiajing
pushed a commit
to hjiajing/antrea
that referenced
this pull request
Jul 28, 2022
1, Use a single routine to send local multicast groups in an IGMP v3
Report message to notify all the other Nodes in the cluster
2. Multicast controller maintains both local Pod members and remote
Nodes which has Pod members for each multicast group found in the
cluster
3. Add remote Node members in the OpenFlow group buckets.
4. Agent drops the duplicated multicast packet received from underlay by
- adding iptables rules in raw table antreaPreRouting chain to drop
multicast packets sent from other Nodes, because the Pod multicast
traffic is received from tunnel with encap mode.
- adding an ipset to maintain IPs of other Nodes in the cluster, which
is used as source in the iptables rule.
Signed-off-by: wenyingd <[email protected]>
tnqn
added
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report message to notify all the other Nodes in the cluster
Nodes which have Pod members for each multicast group found in the
cluster
Signed-off-by: wenyingd [email protected]