Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload Multi-cluster e2e coverage to codecov #3942

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Upload Multi-cluster e2e coverage to codecov #3942

merged 1 commit into from
Jul 5, 2022

Conversation

luolanzone
Copy link
Contributor

@luolanzone luolanzone commented Jun 27, 2022 •
edited
Loading

  1. Add a new target on Makefile to build MC controller image with
    instrumented binary
  2. Add steps on test-mc.sh to collect coverage files from leader and member cluster
    controllers and upload it to codecov

This is a part of #3943
Signed-off-by: Lan Luo [email protected]

@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022 •
edited
Loading

Codecov Report

Merging #3942 (040948e) into main (79b6480) will decrease coverage by 10.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3942       +/-   ##
===========================================
- Coverage   64.39%   54.31%   -10.09%     
===========================================
  Files         294      416      +122     
  Lines       43627    60766    +17139     
===========================================
+ Hits        28095    33004     +4909     
- Misses      13258    25028    +11770     
- Partials     2274     2734      +460
Flag Coverage Δ
integration-tests 35.22% <ø> (?)
kind-e2e-tests 44.94% <ø> (-5.85%) ⬇️
unit-tests 44.38% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pkg/agent/proxy/endpointslicecache.go 0.00% <0.00%> (-86.31%) ⬇️
pkg/agent/secondarynetwork/cnipodcache/cache.go 0.00% <0.00%> (-77.56%) ⬇️
pkg/controller/egress/store/egressgroup.go 1.72% <0.00%> (-54.32%) ⬇️
...g/agent/controller/serviceexternalip/controller.go 35.83% <0.00%> (-45.74%) ⬇️
pkg/agent/secondarynetwork/podwatch/controller.go 0.00% <0.00%> (-36.48%) ⬇️
pkg/agent/util/net.go 28.57% <0.00%> (-23.38%) ⬇️
...nt/apiserver/handlers/serviceexternalip/handler.go 29.62% <0.00%> (-22.23%) ⬇️
pkg/agent/route/route_linux.go 28.11% <0.00%> (-19.85%) ⬇️
pkg/agent/openflow/pod_connectivity.go 46.62% <0.00%> (-19.67%) ⬇️
pkg/agent/ipassigner/responder/arp_responder.go 55.29% <0.00%> (-17.65%) ⬇️
... and 173 more

@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

@luolanzone luolanzone force-pushed the add-mc-e2e-coverage branch from b8b4264 to 4248262 Compare June 27, 2022 06:45
@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

@luolanzone luolanzone force-pushed the add-mc-e2e-coverage branch from 4248262 to 97bb566 Compare June 27, 2022 07:24
@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

@luolanzone luolanzone force-pushed the add-mc-e2e-coverage branch from 97bb566 to d6417e6 Compare June 27, 2022 08:03
@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

@luolanzone luolanzone added the area/multi-cluster Issues or PRs related to multi cluster. label Jun 27, 2022
@luolanzone luolanzone changed the title Upload Multi-cluster e2e coverage to codecov [WIP]Upload Multi-cluster e2e coverage to codecov Jun 27, 2022
@luolanzone luolanzone force-pushed the add-mc-e2e-coverage branch from d6417e6 to 66f57d6 Compare June 29, 2022 03:34
@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

1 similar comment
@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

@luolanzone luolanzone force-pushed the add-mc-e2e-coverage branch from 66f57d6 to 241c83d Compare June 29, 2022 05:22
@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

@luolanzone luolanzone force-pushed the add-mc-e2e-coverage branch from 241c83d to 38f0478 Compare June 30, 2022 01:06
@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

1 similar comment
@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

@luolanzone
Copy link
Contributor Author

/test-multicluster-integration

@luolanzone luolanzone force-pushed the add-mc-e2e-coverage branch from 38f0478 to b2c23b7 Compare June 30, 2022 03:18
@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e
/test-multicluster-integration

@luolanzone luolanzone force-pushed the add-mc-e2e-coverage branch from b2c23b7 to c76bcd7 Compare June 30, 2022 03:52
@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e
/test-multicluster-integration

@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

@luolanzone luolanzone changed the title [WIP]Upload Multi-cluster e2e coverage to codecov Upload Multi-cluster e2e coverage to codecov Jun 30, 2022
jianjuns
jianjuns reviewed Jun 30, 2022
View reviewed changes
Copy link
Contributor

@jianjuns jianjuns left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo

ci/jenkins/test-mc.sh Outdated Show resolved Hide resolved
@luolanzone luolanzone force-pushed the add-mc-e2e-coverage branch from c76bcd7 to 149a6b1 Compare July 4, 2022 01:17
@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

@luolanzone
Upload multi-cluster e2e coverage to codecov
040948e 
1. Add a new target on Makefile to build MC controller image with
   instrumented binary
2. Add steps on test-mc.sh to collect coverage files from leader and member cluster
   controllers and upload it to codecov

Signed-off-by: Lan Luo <[email protected]>
@luolanzone luolanzone force-pushed the add-mc-e2e-coverage branch from 149a6b1 to 040948e Compare July 5, 2022 10:46
@luolanzone
Copy link
Contributor Author

/test-multicluster-e2e

@jianjuns
Copy link
Contributor

jianjuns commented Jul 5, 2022

/skip-all
The change impacts only multi-cluster tests.

@jianjuns jianjuns merged commit 6bbdb2a into antrea-io:main Jul 5, 2022
@luolanzone luolanzone deleted the add-mc-e2e-coverage branch July 6, 2022 02:19
@luolanzone luolanzone mentioned this pull request Jul 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianjuns jianjuns jianjuns approved these changes

@hjiajing hjiajing Awaiting requested review from hjiajing

@antoninbas antoninbas Awaiting requested review from antoninbas

@tnqn tnqn Awaiting requested review from tnqn

Assignees
No one assigned
Labels
area/multi-cluster Issues or PRs related to multi cluster.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luolanzone @codecov-commenter @jianjuns