Update Precedence config and resources output #3930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luolanzone
requested review from
jianjuns and
aravindakidambi
and removed request for
jianjuns
Codecov Report
@@ Coverage Diff @@
## main #3930 +/- ##
===========================================
+ Coverage 35.47% 55.22% +19.75%
===========================================
Files 122 415 +293
Lines 17305 60346 +43041
===========================================
+ Hits 6139 33329 +27190
- Misses 10657 24336 +13679
- Partials 509 2681 +2172
Flags with carried forward coverage won't be shown. Click here to find out more.
|
luolanzone
force-pushed
the
multicluster-configs
branch
from
0810d4a to
1ab4245
Compare
|
/test-multicluster-e2e |
jianjuns
reviewed
Jun 23, 2022
yes, I am working on cleaning up dead codes in another branch, it's still on-going, I may create a new PR today. |
luolanzone
force-pushed
the
multicluster-configs
branch
from
1ab4245 to
9caf714
Compare
jianjuns
reviewed
Jun 23, 2022
docs/multicluster/user-guide.md
Outdated
| is created for cluster `test-cluster-east`. You can check the | ||
| `ClusterInfoImport` with command: `kubectl get clusterinfoimport -o yaml`, | ||
| which should show information like: | ||
| is created for cluster `test-cluster-east`. You can check it with command: |
There was a problem hiding this comment.
Maybe remove "You can check it with command".
%s/. You can check it with command:/:
luolanzone
force-pushed
the
multicluster-configs
branch
from
9caf714 to
9794a2d
Compare
jianjuns
reviewed
Jun 23, 2022
1. Update GatewayIPPrecedence to support "external/internal" option which is requal to `public/private`. 2. Update MC doc to add more columns info. 3. Exclude leader in the totalClusters in ClusterSet status since MC supports one leader only. Signed-off-by: Lan Luo <[email protected]>
luolanzone
force-pushed
the
multicluster-configs
branch
from
9794a2d to
17ef0e3
Compare
jianjuns
approved these changes
Jun 23, 2022
|
/test-multicluster-e2e |
2 similar comments
|
/test-multicluster-e2e |
|
/test-multicluster-e2e |
|
/skip-all |
tnqn
added
the
action/release-note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which is equal to
public/private.supports one leader only.
Signed-off-by: Lan Luo [email protected]