Fix pool CRD format in egress.md and service-loadbalancer.md #3885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianjuns
added
kind/documentation
xliuxu
reviewed
Jun 10, 2022
jianjuns
changed the title
xliuxu
previously approved these changes
Jun 11, 2022
tnqn
previously approved these changes
Jun 13, 2022
docs/egress.md
Outdated
| kind: Egress | ||
| apiVersion: crd.antrea.io/v1alpha2 |
There was a problem hiding this comment.
nit: why revert kind and apiVersion's order? all K8s examples put apiVersion in the first line, and it's the default order when getting one resource's yaml via kubectl.
https://kubernetes.io/docs/concepts/services-networking/service/#defining-a-service
https://kubernetes.io/docs/concepts/services-networking/network-policies/#networkpolicy-resource
There was a problem hiding this comment.
Humm.. In this doc, ConfigMap has kind before apiVersion. Probably let me change that together.
Signed-off-by: Jianjun Shen <[email protected]>
tnqn
approved these changes
Jun 13, 2022
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jianjun Shen [email protected]