[ExternalNode] Handle ExternalNode from Antrea agent side #3799

mengdie-song · 2022-05-17T04:54:48Z

Provide an example RBAC yaml file for Antrea agent running
on VM with definitions of ClusterRole, ServiceAccount and
ClusterRoleBinding.
Add ExternalNodeController to monitor ExternalNode CRUD,
invoke interfaces to operate OVS and update interface store
with ExternalEntityInterface.
Implement OVS interactions related to ExternalNode CRUD.
Add a channel for receiving ExternalEntity updates from
ExternalNodeController and notifying NetworkPolicyController
to reconcile rules related to the updated ExternalEntities.
This is to handle the case when NetworkPolicyController reconciles
rules before ExternalEntityInterface is realized in the
interface store.
Support configuring policy bypass rules to skip ANP check.

Signed-off-by: Mengdie Song [email protected]
Co-authored-by: Wenying Dong [email protected]

codecov-commenter · 2022-05-17T05:02:09Z

Codecov Report

Merging #3799 (85e4f5f) into feature/externalnode (307ba74) will increase coverage by 2.83%.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##           feature/externalnode    #3799      +/-   ##
========================================================
+ Coverage                 63.40%   66.23%   +2.83%     
========================================================
  Files                       291      303      +12     
  Lines                     41823    45180    +3357     
========================================================
+ Hits                      26517    29925    +3408     
+ Misses                    13155    12910     -245     
- Partials                   2151     2345     +194

Flag	Coverage Δ
e2e-tests	`39.91% <ø> (?)`
integration-tests	`35.97% <ø> (?)`
kind-e2e-tests	`49.43% <ø> (-1.41%)`	⬇️
unit-tests	`43.90% <ø> (-0.22%)`	⬇️

Impacted Files	Coverage Δ
...icluster/cmd/multicluster-controller/controller.go	`8.33% <ø> (+1.88%)`	⬆️
multicluster/cmd/multicluster-controller/leader.go	`0.00% <ø> (ø)`
...icluster/controllers/multicluster/common/helper.go	`58.00% <ø> (ø)`
...lticluster/commonarea/resourceimport_controller.go	`77.73% <ø> (+8.38%)`	⬆️
...uster/controllers/multicluster/controller_utils.go	`27.55% <ø> (ø)`
...ter/controllers/multicluster/gateway_controller.go	`44.51% <ø> (+0.68%)`	⬆️
...llers/multicluster/leader_clusterset_controller.go	`64.02% <ø> (+0.26%)`	⬆️
...llers/multicluster/member_clusterset_controller.go	`72.17% <ø> (+62.43%)`	⬆️
...s/multicluster/memberclusterannounce_controller.go	`71.79% <ø> (+6.79%)`	⬆️
...luster/controllers/multicluster/node_controller.go	`65.95% <ø> (+0.36%)`	⬆️
... and 136 more

mengdie-song · 2022-06-01T01:42:36Z

/test-all

pkg/config/agent/config.go

lgtm-com · 2022-06-14T09:57:39Z

This pull request introduces 2 alerts when merging f6a837f into 2554975 - view on LGTM.com

new alerts:

1 for Incorrect conversion between integer types
1 for Useless assignment to local variable

lgtm-com · 2022-06-14T11:23:07Z

This pull request introduces 2 alerts when merging 7c4624b into 2554975 - view on LGTM.com

new alerts:

1 for Incorrect conversion between integer types
1 for Useless assignment to local variable

lgtm-com · 2022-06-15T09:23:42Z

This pull request introduces 1 alert when merging dda83b7 into 2554975 - view on LGTM.com

new alerts:

1 for Incorrect conversion between integer types

lgtm-com · 2022-06-16T09:51:08Z

This pull request introduces 1 alert when merging c40d85b into 2554975 - view on LGTM.com

new alerts:

1 for Incorrect conversion between integer types

lgtm-com · 2022-06-16T11:36:38Z

This pull request introduces 1 alert when merging 330c51a into 2554975 - view on LGTM.com

new alerts:

1 for Incorrect conversion between integer types

lgtm-com · 2022-06-20T09:45:52Z

This pull request introduces 1 alert when merging 036cab6 into 2554975 - view on LGTM.com

new alerts:

1 for Incorrect conversion between integer types

tnqn

LGTM, one minor comment, and the commit body is not aligned properly

pkg/agent/externalnode/external_node_controller.go

wenyingd

LGTM

tnqn · 2022-08-02T03:36:38Z

@mengdie-song where is this change?

Update NetworkPolicy reconciler to invoke GetInterfacesByEntity()
and GetContainerInterfacesByPod() for ExternalEntity and
Pod separately.

mengdie-song · 2022-08-02T03:50:45Z

@tnqn Thanks a lot for the careful review. I realized that we have moved this part into a separate PR #3768 which has already been merged. I have updated the commit message.

1. Provide an example RBAC yaml file for Antrea agent running on VM with definitions of ClusterRole, ServiceAccount and ClusterRoleBinding. 2. Add ExternalNodeController to monitor ExternalNode CRUD, invoke interfaces to operate OVS and update interface store with ExternalEntityInterface. 3. Implement OVS interactions related to ExternalNode CRUD. 4. Add a channel for receiving ExternalEntity updates from ExternalNodeController and notifying NetworkPolicyController to reconcile rules related to the updated ExternalEntities. This is to handle the case when NetworkPolicyController reconciles rules before ExternalEntityInterface is realized in the interface store. 5. Support configuring policy bypass rules to skip ANP check. Signed-off-by: Mengdie Song <[email protected]> Co-authored-by: Wenying Dong <[email protected]>

tnqn

LGTM

tnqn · 2022-08-02T06:41:21Z

Go / Verify docs and spelling (pull_request) Failing after 17s — Verify docs and spelling

Checking table of contents are up to date...
2022/08/02 04:03:12 docs/vm-installation.md: missing opening TOC tag

wenyingd · 2022-08-02T06:42:58Z

Go / Verify docs and spelling (pull_request) Failing after 17s — Verify docs and spelling
Checking table of contents are up to date...
2022/08/02 04:03:12 docs/vm-installation.md: missing opening TOC tag

This will be resolved in another PR for documentation: #3963

wenyingd · 2022-08-02T06:48:33Z

/test-all

…3799) 1. Provide an example RBAC yaml file for Antrea agent running on VM with definitions of ClusterRole, ServiceAccount and ClusterRoleBinding. 2. Add ExternalNodeController to monitor ExternalNode CRUD, invoke interfaces to operate OVS and update interface store with ExternalEntityInterface. 3. Implement OVS interactions related to ExternalNode CRUD. 4. Add a channel for receiving ExternalEntity updates from ExternalNodeController and notifying NetworkPolicyController to reconcile rules related to the updated ExternalEntities. This is to handle the case when NetworkPolicyController reconciles rules before ExternalEntityInterface is realized in the interface store. 5. Support configuring policy bypass rules to skip ANP check. Signed-off-by: Mengdie Song <[email protected]> Co-authored-by: Wenying Dong <[email protected]>

1. Provide an example RBAC yaml file for Antrea agent running on VM with definitions of ClusterRole, ServiceAccount and ClusterRoleBinding. 2. Add ExternalNodeController to monitor ExternalNode CRUD, invoke interfaces to operate OVS and update interface store with ExternalEntityInterface. 3. Implement OVS interactions related to ExternalNode CRUD. 4. Add a channel for receiving ExternalEntity updates from ExternalNodeController and notifying NetworkPolicyController to reconcile rules related to the updated ExternalEntities. This is to handle the case when NetworkPolicyController reconciles rules before ExternalEntityInterface is realized in the interface store. 5. Support configuring policy bypass rules to skip ANP check. Signed-off-by: Mengdie Song <[email protected]> Co-authored-by: wenyingd <[email protected]>

…3799) 1. Provide an example RBAC yaml file for Antrea agent running on VM with definitions of ClusterRole, ServiceAccount and ClusterRoleBinding. 2. Add ExternalNodeController to monitor ExternalNode CRUD, invoke interfaces to operate OVS and update interface store with ExternalEntityInterface. 3. Implement OVS interactions related to ExternalNode CRUD. 4. Add a channel for receiving ExternalEntity updates from ExternalNodeController and notifying NetworkPolicyController to reconcile rules related to the updated ExternalEntities. This is to handle the case when NetworkPolicyController reconciles rules before ExternalEntityInterface is realized in the interface store. 5. Support configuring policy bypass rules to skip ANP check. Signed-off-by: Mengdie Song <[email protected]> Co-authored-by: wenyingd <[email protected]>

1. Provide an example RBAC yaml file for Antrea agent running on VM with definitions of ClusterRole, ServiceAccount and ClusterRoleBinding. 2. Add ExternalNodeController to monitor ExternalNode CRUD, invoke interfaces to operate OVS and update interface store with ExternalEntityInterface. 3. Implement OVS interactions related to ExternalNode CRUD. 4. Add a channel for receiving ExternalEntity updates from ExternalNodeController and notifying NetworkPolicyController to reconcile rules related to the updated ExternalEntities. This is to handle the case when NetworkPolicyController reconciles rules before ExternalEntityInterface is realized in the interface store. 5. Support configuring policy bypass rules to skip ANP check. Signed-off-by: Mengdie Song <[email protected]> Co-authored-by: wenyingd <[email protected]>

…3799) 1. Provide an example RBAC yaml file for Antrea agent running on VM with definitions of ClusterRole, ServiceAccount and ClusterRoleBinding. 2. Add ExternalNodeController to monitor ExternalNode CRUD, invoke interfaces to operate OVS and update interface store with ExternalEntityInterface. 3. Implement OVS interactions related to ExternalNode CRUD. 4. Add a channel for receiving ExternalEntity updates from ExternalNodeController and notifying NetworkPolicyController to reconcile rules related to the updated ExternalEntities. This is to handle the case when NetworkPolicyController reconciles rules before ExternalEntityInterface is realized in the interface store. 5. Support configuring policy bypass rules to skip ANP check. Signed-off-by: Mengdie Song <[email protected]> Co-authored-by: wenyingd <[email protected]>

wenyingd force-pushed the feature/externalnode branch from 7242689 to 9a0bf16 Compare May 20, 2022 04:39

wenyingd force-pushed the feature/externalnode branch 2 times, most recently from 3d5f3f5 to 9c7554a Compare May 27, 2022 09:33

mengdie-song force-pushed the feature-externalnode-agent branch from 004ba82 to 87abc07 Compare May 31, 2022 09:06

XinShuYang force-pushed the feature-externalnode-agent branch 2 times, most recently from 5df5815 to f9671a4 Compare June 2, 2022 03:46

wenyingd force-pushed the feature/externalnode branch from e7ce899 to 67f3dc9 Compare June 6, 2022 03:11

mengdie-song force-pushed the feature-externalnode-agent branch from f9671a4 to 2235866 Compare June 9, 2022 09:48

wenyingd force-pushed the feature/externalnode branch from a4cc52a to 2554975 Compare June 9, 2022 09:58

mengdie-song force-pushed the feature-externalnode-agent branch from 2235866 to e404f1a Compare June 10, 2022 01:54

wenyingd reviewed Jun 10, 2022

View reviewed changes

pkg/config/agent/config.go Outdated Show resolved Hide resolved

mengdie-song force-pushed the feature-externalnode-agent branch 2 times, most recently from 96de75f to f6a837f Compare June 14, 2022 09:33

mengdie-song force-pushed the feature-externalnode-agent branch from f6a837f to 7c4624b Compare June 14, 2022 10:56

mengdie-song force-pushed the feature-externalnode-agent branch from 7c4624b to dda83b7 Compare June 15, 2022 08:54

XinShuYang force-pushed the feature-externalnode-agent branch from dda83b7 to c40d85b Compare June 16, 2022 09:22

XinShuYang force-pushed the feature-externalnode-agent branch from c40d85b to 330c51a Compare June 16, 2022 11:09

mengdie-song force-pushed the feature-externalnode-agent branch from 330c51a to 036cab6 Compare June 20, 2022 09:07

mengdie-song force-pushed the feature-externalnode-agent branch 2 times, most recently from ae2a0a1 to 5557fdd Compare June 21, 2022 08:06

mengdie-song requested review from jianjuns and tnqn June 21, 2022 08:23

XinShuYang force-pushed the feature-externalnode-agent branch from 30c266b to 834f346 Compare July 29, 2022 08:43

tnqn reviewed Aug 1, 2022

View reviewed changes

pkg/agent/externalnode/external_node_controller.go Outdated Show resolved Hide resolved

mengdie-song force-pushed the feature-externalnode-agent branch from 834f346 to 2d1ef2a Compare August 2, 2022 01:47

wenyingd reviewed Aug 2, 2022

View reviewed changes

mengdie-song force-pushed the feature-externalnode-agent branch from 2d1ef2a to 7f28851 Compare August 2, 2022 03:47

mengdie-song force-pushed the feature-externalnode-agent branch from 7f28851 to 81abd06 Compare August 2, 2022 03:54

mengdie-song force-pushed the feature-externalnode-agent branch from 81abd06 to 85e4f5f Compare August 2, 2022 03:56

tnqn approved these changes Aug 2, 2022

View reviewed changes

tnqn added kind/feature Categorizes issue or PR as related to a new feature. action/release-note Indicates a PR that should be included in release notes. labels Aug 2, 2022

mengdie-song merged commit 18595a8 into antrea-io:feature/externalnode Aug 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ExternalNode] Handle ExternalNode from Antrea agent side #3799

[ExternalNode] Handle ExternalNode from Antrea agent side #3799

mengdie-song commented May 17, 2022 •

edited

Loading

codecov-commenter commented May 17, 2022 •

edited by codecov bot

Loading

mengdie-song commented Jun 1, 2022

lgtm-com bot commented Jun 14, 2022

lgtm-com bot commented Jun 14, 2022

lgtm-com bot commented Jun 15, 2022

lgtm-com bot commented Jun 16, 2022

lgtm-com bot commented Jun 16, 2022

lgtm-com bot commented Jun 20, 2022

tnqn left a comment

wenyingd left a comment

tnqn commented Aug 2, 2022

mengdie-song commented Aug 2, 2022

tnqn left a comment

tnqn commented Aug 2, 2022

wenyingd commented Aug 2, 2022

wenyingd commented Aug 2, 2022

[ExternalNode] Handle ExternalNode from Antrea agent side #3799

[ExternalNode] Handle ExternalNode from Antrea agent side #3799

Conversation

mengdie-song commented May 17, 2022 • edited Loading

codecov-commenter commented May 17, 2022 • edited by codecov bot Loading

Codecov Report

mengdie-song commented Jun 1, 2022

lgtm-com bot commented Jun 14, 2022

lgtm-com bot commented Jun 14, 2022

lgtm-com bot commented Jun 15, 2022

lgtm-com bot commented Jun 16, 2022

lgtm-com bot commented Jun 16, 2022

lgtm-com bot commented Jun 20, 2022

tnqn left a comment

Choose a reason for hiding this comment

wenyingd left a comment

Choose a reason for hiding this comment

tnqn commented Aug 2, 2022

mengdie-song commented Aug 2, 2022

tnqn left a comment

Choose a reason for hiding this comment

tnqn commented Aug 2, 2022

wenyingd commented Aug 2, 2022

wenyingd commented Aug 2, 2022

mengdie-song commented May 17, 2022 •

edited

Loading

codecov-commenter commented May 17, 2022 •

edited by codecov bot

Loading