Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #3630: Bump antrea.io/ofnet from v0.5.5 to v0.5.7 #3510: Fix the issue of local probe bypassing flows on Windows #3761

Conversation

hongliangl
Copy link
Contributor

Cherry pick of #3630 #3510 on release-1.5.

#3630: Bump antrea.io/ofnet from v0.5.5 to v0.5.7
#3510: Fix the issue of local probe bypassing flows on Windows

For details on the cherry pick process, see the cherry pick requests page.

@hongliangl hongliangl added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label May 10, 2022
@hongliangl hongliangl force-pushed the automated-cherry-pick-of-#3630-#3510-upstream-release-1.5 branch from 7fc31e6 to 4c85f08 Compare May 10, 2022 15:48
@hongliangl
Copy link
Contributor Author

/test-all
/test-windows-all

@hongliangl hongliangl requested a review from tnqn May 10, 2022 15:50
@tnqn
Copy link
Member

tnqn commented May 10, 2022

Need to remove pkg/agent/openflow/pod_connectivity.go. But I just found release-1.5 doesn't have the issue described in #3680 because the bypass flow is in a table after dns flow, am I right?

@hongliangl hongliangl force-pushed the automated-cherry-pick-of-#3630-#3510-upstream-release-1.5 branch from 4c85f08 to 61ad71e Compare May 11, 2022 01:25
When proxyAll is enabled, kube-proxy can be replaced by AntreaProxy, then
Service traffic and non-Service traffic can be distinguished by ServiceCTMark
and NotServiceCTMark. Service traffic with ServiceCTMark should not bypass
Network Policies, and non-Service traffic generated by kubelet with
NotServiceCTMark should bypass Network Policies.

Signed-off-by: Hongliang Liu <[email protected]>
@hongliangl hongliangl force-pushed the automated-cherry-pick-of-#3630-#3510-upstream-release-1.5 branch from 61ad71e to e7581b0 Compare May 11, 2022 01:54
@codecov-commenter
Copy link

Codecov Report

Merging #3761 (e7581b0) into release-1.5 (9d35d65) will decrease coverage by 19.39%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-1.5    #3761       +/-   ##
================================================
- Coverage        60.82%   41.42%   -19.40%     
================================================
  Files              333      200      -133     
  Lines            28536    24164     -4372     
================================================
- Hits             17356    10011     -7345     
- Misses            9282    13120     +3838     
+ Partials          1898     1033      -865     
Flag Coverage Δ
kind-e2e-tests ?
unit-tests 41.42% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/openflow/client.go 22.26% <0.00%> (-34.44%) ⬇️
pkg/agent/openflow/pipeline.go 20.97% <0.00%> (-57.15%) ⬇️
pkg/ovs/openflow/default.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/util/runtime/runtime.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/agent/nodeportlocal/k8s/annotations.go 0.00% <0.00%> (-93.55%) ⬇️
pkg/ovs/openflow/logs.go 9.52% <0.00%> (-90.48%) ⬇️
pkg/apis/controlplane/register.go 0.00% <0.00%> (-90.00%) ⬇️
pkg/agent/controller/networkpolicy/reject.go 0.00% <0.00%> (-81.35%) ⬇️
pkg/agent/client.go 0.00% <0.00%> (-77.42%) ⬇️
pkg/ovs/ovsconfig/ovs_client_linux.go 0.00% <0.00%> (-76.93%) ⬇️
... and 251 more

@hongliangl hongliangl closed this May 11, 2022
@hongliangl
Copy link
Contributor Author

hongliangl commented May 11, 2022

@tnqn You are right, it's only in 1.6. Close the PR.

@hongliangl hongliangl deleted the automated-cherry-pick-of-#3630-#3510-upstream-release-1.5 branch May 11, 2022 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants