Fix importer issue after leader controller restart #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-multicluster-e2e |
Codecov Report
@@ Coverage Diff @@
## main #3596 +/- ##
===========================================
- Coverage 64.26% 53.80% -10.46%
===========================================
Files 278 392 +114
Lines 27821 43110 +15289
===========================================
+ Hits 17878 23196 +5318
- Misses 8045 17613 +9568
- Partials 1898 2301 +403
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jianjuns
reviewed
Apr 7, 2022
1. Reset common area's cluster manager so it can be started again when member cluster disconnects from leader and reconnects. Otherwise, it will raise an error `can't accept new runnable as stop procedure is already engaged` 2. Always update the ResourceImport cache for importer so it can handle deletion event correctly. Signed-off-by: Lan Luo <[email protected]>
luolanzone
force-pushed
the
fix-disconnect-issue
branch
from
4368965 to
814dff8
Compare
message is updated now. thanks. |
jianjuns
approved these changes
Apr 8, 2022
tnqn
added
kind/bug
tnqn
approved these changes
Apr 12, 2022
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset common area's cluster manager so it can be started again
when member cluster disconnects from leader and reconnects. Otherwise,
it will raise an error
can't accept new runnable as stop procedure is already engaged.Always update the ResourceImport cache for importer so it can handle
deletion event correctly.
Fixes #3593
Signed-off-by: Lan Luo [email protected]