Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multicluster E2E Test Refactor #3286

Closed
wants to merge 1 commit into from
Closed

Multicluster E2E Test Refactor #3286

wants to merge 1 commit into from

Conversation

enhaocui
Copy link

@enhaocui enhaocui commented Feb 9, 2022

No description provided.

@luolanzone luolanzone added the area/multi-cluster Issues or PRs related to multi cluster. label Feb 9, 2022
Dyanngg
Dyanngg reviewed Feb 15, 2022
View reviewed changes
multicluster/test/e2e/service_test.go Outdated Show resolved Hide resolved
multicluster/test/e2e/service_test.go Outdated Show resolved Hide resolved
@Dyanngg
Copy link
Contributor

Dyanngg commented Feb 15, 2022

@enhaocui As a first time commit to Antrea please also check how to fix DCO https://github.com/antrea-io/antrea/pull/3286/checks?check_run_id=5119327714

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022 •
edited
Loading

Codecov Report

Merging #3286 (b3e987f) into main (e23cf3b) will increase coverage by 4.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3286      +/-   ##
==========================================
+ Coverage   60.12%   64.14%   +4.01%     
==========================================
  Files         331      268      -63     
  Lines       28444    26780    -1664     
==========================================
+ Hits        17102    17178      +76     
+ Misses       9483     7723    -1760     
- Partials     1859     1879      +20
Flag Coverage Δ
kind-e2e-tests 53.53% <ø> (+5.58%) ⬆️
unit-tests 42.59% <ø> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/util/ethtool/ethtool_linux.go 0.00% <0.00%> (-70.00%) ⬇️
pkg/agent/openflow/meters_linux.go 36.36% <0.00%> (-18.19%) ⬇️
pkg/agent/nodeportlocal/npl_agent_init.go 66.66% <0.00%> (-17.95%) ⬇️
pkg/agent/flowexporter/exporter/certificate.go 33.33% <0.00%> (-16.67%) ⬇️
pkg/agent/nodeportlocal/k8s/annotations.go 83.87% <0.00%> (-16.13%) ⬇️
pkg/agent/route/route_linux.go 30.38% <0.00%> (-16.11%) ⬇️
pkg/agent/util/net.go 26.66% <0.00%> (-13.47%) ⬇️
...kg/agent/controller/networkpolicy/audit_logging.go 85.88% <0.00%> (-10.28%) ⬇️
pkg/apis/controlplane/v1beta2/sets.go 51.21% <0.00%> (-9.76%) ⬇️
pkg/agent/flowexporter/exporter/exporter.go 73.87% <0.00%> (-9.36%) ⬇️
... and 167 more

@enhaocui enhaocui changed the title [WIP] Multicluster E2E Test Refactor Multicluster E2E Test Refactor Feb 24, 2022
@enhaocui
Copy link
Author

/test-multicluster-e2e

@enhaocui enhaocui requested a review from Dyanngg February 25, 2022 22:08
@Dyanngg
Copy link
Contributor

Dyanngg commented Mar 1, 2022

/test-multicluster-e2e

@enhaocui enhaocui force-pushed the ecui/e2e_refactor branch from d0f84a2 to 924d7e8 Compare March 1, 2022 19:42
@enhaocui
Copy link
Author

enhaocui commented Mar 1, 2022

/test-multicluster-e2e

1 similar comment
@enhaocui
Copy link
Author

enhaocui commented Mar 1, 2022

/test-multicluster-e2e

@enhaocui enhaocui force-pushed the ecui/e2e_refactor branch from 924d7e8 to b47cb18 Compare March 2, 2022 19:40
@enhaocui
Copy link
Author

enhaocui commented Mar 2, 2022

/test-multicluster-e2e

@enhaocui enhaocui force-pushed the ecui/e2e_refactor branch from b47cb18 to 77583ce Compare March 3, 2022 23:09
@luolanzone
Copy link
Contributor

@tnqn Could you help to click approve and run button to run workflows, since this is first commit from @enhaocui , those github check is not triggered. thanks.

@Dyanngg
Copy link
Contributor

Dyanngg commented Mar 4, 2022

/test-multicluster-e2e

Dyanngg
Dyanngg reviewed Mar 4, 2022
View reviewed changes
Copy link
Contributor

@Dyanngg Dyanngg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I believe we've talked about splitting the ServiceExport and ACNP toService to two separate testcases. Is it not reflected in the PR?

multicluster/test/e2e/service_test.go Outdated Show resolved Hide resolved
@Dyanngg Dyanngg requested a review from hjiajing March 4, 2022 21:17
@Dyanngg
Copy link
Contributor

Dyanngg commented Mar 4, 2022

/cc @hjiajing for awareness

@Dyanngg Dyanngg mentioned this pull request Mar 9, 2022
Merged
luolanzone
luolanzone reviewed Mar 16, 2022
View reviewed changes
multicluster/test/e2e/service_test.go Outdated Show resolved Hide resolved
multicluster/test/e2e/service_test.go Outdated Show resolved Hide resolved
multicluster/test/e2e/service_test.go Outdated Show resolved Hide resolved
multicluster/test/e2e/service_test.go Outdated Show resolved Hide resolved
multicluster/test/e2e/service_test.go Outdated Show resolved Hide resolved
@enhaocui enhaocui force-pushed the ecui/e2e_refactor branch from 919beb7 to f3ef915 Compare March 17, 2022 22:34
@enhaocui
Copy link
Author

/test-multicluster-e2e

1 similar comment
@enhaocui
Copy link
Author

/test-multicluster-e2e

@enhaocui enhaocui requested a review from Dyanngg March 21, 2022 21:24
@enhaocui enhaocui force-pushed the ecui/e2e_refactor branch from f3ef915 to b3e987f Compare March 22, 2022 00:30
@enhaocui
Copy link
Author

/test-multicluster-e2e

@Dyanngg
Copy link
Contributor

Dyanngg commented Mar 22, 2022

/test-integration

@luolanzone luolanzone mentioned this pull request Mar 23, 2022
Merged
@enhaocui
Copy link
Author

/test-networkpolicy

@enhaocui enhaocui force-pushed the ecui/e2e_refactor branch from b3e987f to 5601898 Compare March 31, 2022 23:58
@enhaocui
Copy link
Author

enhaocui commented Apr 1, 2022

/test-multicluster-e2e

Dyanngg
Dyanngg reviewed Apr 1, 2022
View reviewed changes
multicluster/test/e2e/service_test.go Outdated Show resolved Hide resolved
multicluster/test/e2e/service_test.go Outdated Show resolved Hide resolved
@Dyanngg
Copy link
Contributor

Dyanngg commented Apr 1, 2022

Please also provide a brief description of the PR

@enhaocui enhaocui force-pushed the ecui/e2e_refactor branch from 5601898 to 751e242 Compare April 4, 2022 19:49
@enhaocui
Copy link
Author

enhaocui commented Apr 4, 2022

/test-multicluster-e2e

@enhaocui
Copy link
Author

enhaocui commented Apr 4, 2022

/test-integration /test-multicluster-e2e

@enhaocui
Copy link
Author

enhaocui commented Apr 5, 2022

/test-all /test-integration

@enhaocui enhaocui requested a review from Dyanngg April 5, 2022 18:11
Multicluster E2E Test Refactoring
5d473e8 
Grouped multicluster service export test cases together, and
trigger the test cases from multicluster/test/e2e/main_test.go

Signed-off-by: Enhao Cui <[email protected]>
@enhaocui enhaocui force-pushed the ecui/e2e_refactor branch from 751e242 to 5d473e8 Compare April 5, 2022 22:37
@enhaocui
Copy link
Author

enhaocui commented Apr 6, 2022

/test-multicluster-e2e

@GraysonWu GraysonWu mentioned this pull request Jun 7, 2022
Merged
@luolanzone
Copy link
Contributor

Close this one since it's replaced by #3863

@luolanzone luolanzone closed this Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiajing hjiajing Awaiting requested review from hjiajing

@luolanzone luolanzone Awaiting requested review from luolanzone

@salv-orlando salv-orlando Awaiting requested review from salv-orlando

@Dyanngg Dyanngg Awaiting requested review from Dyanngg

Assignees
No one assigned
Labels
area/multi-cluster Issues or PRs related to multi cluster.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@enhaocui @Dyanngg @codecov-commenter @luolanzone @salv-orlando