Remove unncessary mutex usage in the secondary network CNI cache #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cache itself uses cache.Indexer which is thread-safe, and so needs not the mutex to protect cache accesses. The mutex should be used just for protecting CNIConfigInfo.PodCNIDeleted, which is written by CNIServer and read by the secondary network Pod controller. Signed-off-by: Jianjun Shen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3232 +/- ##
==========================================
+ Coverage 58.76% 59.91% +1.15%
==========================================
Files 331 331
Lines 28437 28429 -8
==========================================
+ Hits 16711 17034 +323
+ Misses 9894 9519 -375
- Partials 1832 1876 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
arunvelayutham
approved these changes
Jan 22, 2022
|
/test-all |
|
/test-integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache itself uses cache.Indexer which is thread-safe, and so needs
not the mutex to protect cache accesses. The mutex should be used just
for protecting CNIConfigInfo.PodCNIDeleted, which is written by
CNIServer and read by the secondary network Pod controller.
Signed-off-by: Jianjun Shen [email protected]