Fix the case of protocol in flow-aggregator doc #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The protocol must be written in lowercase, otherwise the validation would fail. Signed-off-by: Quan Tian <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #3110 +/- ##
===========================================
- Coverage 60.83% 36.34% -24.49%
===========================================
Files 295 329 +34
Lines 24892 37689 +12797
===========================================
- Hits 15142 13698 -1444
- Misses 8095 22690 +14595
+ Partials 1655 1301 -354
Flags with carried forward coverage won't be shown. Click here to find out more.
|
antoninbas
approved these changes
Dec 9, 2021
|
/skip-all |
zyiou
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protocol must be written in lowercase, otherwise the validation
would fail.
Signed-off-by: Quan Tian [email protected]
I followed the doc to deploy flow-aggregator and found it crashed because of this.