-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install flows to skip SNAT for k8s nodes (#2708) #2762
Conversation
/test-e2e |
/test-all |
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the commit message:
If destination IP is nodeIPs, we must skip SNAT if egress is enabled, no need to forward such packets to the egressIP node
When egress is enabled, we should skip SNAT for traffic to a remote Node's transport IP, as no need to forward such packets through an egress Node.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-all |
Codecov Report
@@ Coverage Diff @@
## main #2762 +/- ##
==========================================
+ Coverage 60.72% 65.74% +5.02%
==========================================
Files 283 284 +1
Lines 22839 26946 +4107
==========================================
+ Hits 13868 17715 +3847
- Misses 7498 7552 +54
- Partials 1473 1679 +206
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@leonstack "Go / Golangci-lint" check failed. Could you fix it so we can merge it? |
OK, I will fix it later. |
When egress is enabled, we should skip SNAT for traffic to a remote Node's transport IP, as no need to forward such packets through an egress Node. Signed-off-by: Yang Li <[email protected]>
/test-all |
@tnqn hi, seems everything is OK, can you help review this PR again :-) |
/test-ipv6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm - it wont affect the default masquerade behavior right?
It wont affect the default masquerade behavior, and the pod will use the default masquerade to communicate with other NodeIPs. |
If destination IP is nodeIPs, we must skip SNAT if egress is enabled,
no need to forward such packets to the egressIP node
Signed-off-by: Yang Li [email protected]