Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all remaining references to vmware-tanzu/antrea #2173

Conversation

antoninbas
Copy link
Contributor

With antrea-io/antrea
Most of these are Github links.
We also update the Jenkins job configuration as jobs cannot run at the
moment because of the repository transfer.

See #2154

With antrea-io/antrea
Most of these are Github links.
We also update the Jenkins job configuration as jobs cannot run at the
moment because of the repository transfer.

See antrea-io#2154
@antoninbas antoninbas requested review from jianjuns and tnqn May 12, 2021 21:45
@antoninbas
Copy link
Contributor Author

@lzhecheng sorry I cannot add you as a reviewer until you accept the invite to join the antrea-io Github organization (I only sent it a couple hours ago)

After we merge this, will all the jobs in https://jenkins.antrea-ci.rocks/ be updated, or do we need to update them manually? I started updating them (only did the e2e jobs so far), then realized that by updating these configuration files, it could be done automatically. Is that correct?

jianjuns
jianjuns previously approved these changes May 12, 2021
@lzhecheng
Copy link
Contributor

@antoninbas I joined with your invitation but I don't see the add reviewer button so I think there's still something to do?

This PR looks good to me.

I think without any change, VMC Jenkins cannot be updated automatically since the repo link is wrong. Jenkins don't know it should listen to antrea-io/antrea now instead of old one. However, we don't need to update every job, just the antrea-job-updater one is enough I think. I have updated it just now. It will take care of updating others.

@antoninbas
Copy link
Contributor Author

@lzhecheng could you try again? permission issue should be fixed

@antoninbas
Copy link
Contributor Author

/skip-all

@lzhecheng lzhecheng self-requested a review May 13, 2021 01:55
Copy link
Contributor

@lzhecheng lzhecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzhecheng
Copy link
Contributor

/test-integration
/skip-conformance
/skip-networkpolicy

@lzhecheng
Copy link
Contributor

Ok, skip jobs needs updating first or this PR cannot be merged...

@antoninbas
Copy link
Contributor Author

I'll force merge it manually so the jobs can be updated

@antoninbas antoninbas merged commit 4e185c0 into antrea-io:main May 13, 2021
@antoninbas antoninbas deleted the replace-all-references-to-vmware-tanzu/antrea branch May 13, 2021 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants