Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Octant to v0.16.1 & Add alerts for traceflow UI #1371

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

ZhangYW18
Copy link
Contributor

To add alerts for traceflow UI, we need to upgrade Octant to v0.16.1 first to make alerts available in Octant plugins.
In Octant, alerts appear on the top of webpage like this:
success alert
In default, it will expire after 10 seconds.

When a user creates a traceflow via UI successfully, we will notify the user like the image above.
When there's something illegal in users' input, we will notify the user how it went wrong:
error alert

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-windows-networkpolicy: to trigger windows networkpolicy tests.
  • /skip-windows-networkpolicy: to skip windows networkpolicy tests.
  • /test-hw-offload: to trigger ovs hardware offload test.
  • /skip-hw-offload: to skip ovs hardware offload test.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

@ZhangYW18
Copy link
Contributor Author

@mengdie-song Could you help me add reviewers for this pull request as I do not have permission to do so?

@mengdie-song
Copy link
Contributor

@ZhangYW18 Sure, I will also review this later.

@codecov-io
Copy link

codecov-io commented Oct 14, 2020

Codecov Report

Merging #1371 into master will increase coverage by 3.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1371      +/-   ##
==========================================
+ Coverage   64.59%   67.83%   +3.23%     
==========================================
  Files         159      159              
  Lines       12654    12744      +90     
==========================================
+ Hits         8174     8645     +471     
+ Misses       3629     3191     -438     
- Partials      851      908      +57     
Flag Coverage Δ
#integration-tests 47.54% <ø> (+2.52%) ⬆️
#kind-e2e-tests 55.62% <ø> (+4.80%) ⬆️
#unit-tests 42.27% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/certificate/certificate.go 71.05% <0.00%> (-6.58%) ⬇️
pkg/apis/controlplane/v1beta1/sets.go 39.70% <0.00%> (-4.42%) ⬇️
pkg/apiserver/storage/ram/watch.go 90.38% <0.00%> (-3.85%) ⬇️
...kg/controller/networkpolicy/store/networkpolicy.go 77.96% <0.00%> (-3.39%) ⬇️
pkg/agent/agent.go 49.85% <0.00%> (-2.09%) ⬇️
...ntroller/networkpolicy/networkpolicy_controller.go 67.03% <0.00%> (-1.12%) ⬇️
...ntroller/networkpolicy/networkpolicy_controller.go 80.56% <0.00%> (-0.54%) ⬇️
pkg/agent/controller/networkpolicy/cache.go 84.85% <0.00%> (-0.13%) ⬇️
pkg/antctl/antctl.go 100.00% <0.00%> (ø)
pkg/agent/flowexporter/connections/conntrack.go 84.21% <0.00%> (ø)
... and 16 more

@ZhangYW18 ZhangYW18 force-pushed the tf-ui-fix branch 2 times, most recently from eda67d9 to 94392ef Compare October 16, 2020 03:22
@ZhangYW18 ZhangYW18 force-pushed the tf-ui-fix branch 4 times, most recently from d79d24d to 1972c9d Compare October 20, 2020 02:26
mengdie-song
mengdie-song previously approved these changes Oct 20, 2020
Copy link
Contributor

@mengdie-song mengdie-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZhangYW18
Copy link
Contributor Author

@gran-vmv Will you review this PR?

gran-vmv
gran-vmv previously approved these changes Oct 23, 2020
Copy link
Contributor

@gran-vmv gran-vmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please verify this for common user errors.

@gran-vmv
Copy link
Contributor

/test-all

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Oct 29, 2020

/test-all

@tnqn
Copy link
Member

tnqn commented Oct 29, 2020

I believe the failure in e2e is not related. But just in case, testing another time.
/test-e2e

@tnqn tnqn merged commit 665c62f into antrea-io:master Oct 29, 2020
@ZhangYW18 ZhangYW18 deleted the tf-ui-fix branch December 2, 2020 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants