-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Octant to v0.16.1 & Add alerts for traceflow UI #1371
Conversation
Thanks for your PR. The following commands are available:
|
@mengdie-song Could you help me add reviewers for this pull request as I do not have permission to do so? |
@ZhangYW18 Sure, I will also review this later. |
Codecov Report
@@ Coverage Diff @@
## master #1371 +/- ##
==========================================
+ Coverage 64.59% 67.83% +3.23%
==========================================
Files 159 159
Lines 12654 12744 +90
==========================================
+ Hits 8174 8645 +471
+ Misses 3629 3191 -438
- Partials 851 908 +57
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eda67d9
to
94392ef
Compare
d79d24d
to
1972c9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gran-vmv Will you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please verify this for common user errors.
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-all |
I believe the failure in e2e is not related. But just in case, testing another time. |
To add alerts for traceflow UI, we need to upgrade Octant to v0.16.1 first to make alerts available in Octant plugins.
In Octant, alerts appear on the top of webpage like this:
In default, it will expire after 10 seconds.
When a user creates a traceflow via UI successfully, we will notify the user like the image above.
When there's something illegal in users' input, we will notify the user how it went wrong: