Manifests building with hw-offload is broken due to wrong helm templates
#3705
Assignees
Labels
kind/bug
Categorizes issue or PR as related to a bug.
Comments
|
@antoninbas can i bother you to take a look at the issue, thanks. |
antoninbas
added a commit
to antoninbas/antrea
that referenced
this issue
Apr 29, 2022
s/.Values.hwOffload./.Values.ovs.hwOffload Fixes antrea-io#3705 Signed-off-by: Antonin Bas <[email protected]>
|
Thanks for catching this @AbdYsn. I have submitted a patch. |
|
@antoninbas Thank you very much for taking a look and fixing the issue. |
abdallahyas
changed the title
hw-offload is broken due to wrong helm templates
antoninbas
added a commit
that referenced
this issue
Apr 29, 2022
s/.Values.hwOffload./.Values.ovs.hwOffload Fixes #3705 Signed-off-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Following patch antrea started to use helm to build its manifests, the patch broke the
hw-offloadflag of thehack/generate-manifest.shby having a mismatch between the helm values of generate-manifestes.sh and the helm template.can you guys take a look
To Reproduce
Run generate-manifestes.sh with --hw-offload flag
Expected
having
--hw-offloadarg added to theovs_startcommand on the generated antrea.yml file.Actual behavior
--hw-offloadarg is missing from the generated manifestVersions:
current master
Additional context
The text was updated successfully, but these errors were encountered: