-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No status report from jobs with matrix if they are skipped #3563
Comments
Is it because antrea-io/has-changes#7 caused has-changes always returned "yes"? |
I don't think it is because of |
Fixes antrea-io#3563 Signed-off-by: Quan Tian <[email protected]>
This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days |
Fixes antrea-io#3563 Signed-off-by: Quan Tian <[email protected]>
@antoninbas I found moving "if" condition to steps caused that the skipped jobs were marked as success which may be misleading. To trade off between unnecessary verification, code redundancy, misleading result, I prefer to sacrifice code redundancy, given anyway the code just repeats once and we don't update them very often. |
Do not use jobs with os matrix when any of the expanded jobs are required checks, otherwise the reports would be missing if the job is skipped, causing PRs unmergeable. Fixes antrea-io#3563 Signed-off-by: Quan Tian <[email protected]>
Do not use jobs with os matrix when any of the expanded jobs are required checks, otherwise the reports would be missing if the job is skipped, causing PRs unmergeable. Fixes antrea-io#3563 Signed-off-by: Quan Tian <[email protected]>
Do not use jobs with os matrix when any of the expanded jobs are required checks, otherwise the reports would be missing if the job is skipped, causing PRs unmergeable. Fixes #3563 Signed-off-by: Quan Tian <[email protected]>
Describe the bug
For example, in #3544, there is a status report for "Go / Golangci-lint (pull_request)" (skipped) but no report for "Golangci-lint (macos-latest)" and "Golangci-lint (ubuntu-latest)".
The reason is "Go / Golangci-lint (pull_request)" has matrix defined, but it was skipped before the matrix is expanded but we require the status report of expanded jobs.
There are some discussions on this issue but no solution yet:
actions/runner#952
community/community#9141
The issue causes PRs that have no code change from being merged via the normal process. I'm not sure why there wasn't an issue before. Any idea? @antoninbas
Two workarounds in my mind:
To Reproduce
Create a PR with no code change.
The text was updated successfully, but these errors were encountered: