Improve the cookieSecure config parameter #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We expose it in the Helm chart as security.cookieSecure. The default behavior when installing the Helm chart does not change: if HTTPS is enabled, it is set to true, otherwise it is set to false. However, by exposing it, we enable users who terminate TLS at Ingress (and hence keep HTTPS disabled in Antrea UI) to enable that option, which hardens security. We also enable it by default in the Viper config, which does not really have an impact on users. Note that it is not possible for a non-secure origin (HTTP website) to add the Secure attribute. Most modern browsers will not allow it and the cookie will be discarded. This is why we do not unconditionally set the Secure attribute. This restriction does not apply for localhost. Signed-off-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expose it in the Helm chart as security.cookieSecure. The default behavior when installing the Helm chart does not change: if HTTPS is enabled, it is set to true, otherwise it is set to false. However, by exposing it, we enable users who terminate TLS at Ingress (and hence keep HTTPS disabled in Antrea UI) to enable that option, which hardens security.
We also enable it by default in the Viper config, which does not really have an impact on users.
Note that it is not possible for a non-secure origin (HTTP website) to add the Secure attribute. Most modern browsers will not allow it and the cookie will be discarded. This is why we do not unconditionally set the Secure attribute. This restriction does not apply for localhost.