Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reset image object, not reset the values #23

Merged
merged 1 commit into from
Jan 9, 2019
Merged

fix: reset image object, not reset the values #23

merged 1 commit into from
Jan 9, 2019

Conversation

alxwrd
Copy link
Contributor

@alxwrd alxwrd commented Jan 9, 2019

There is an issue when loading a project. If you click the load button twice, the image disappears. I think this is because RESET_BASIC_FIELDS is mutating the image object.

Click for current behviour

This resets the image state by creating a new object.

Click for new behviour


antonreshetov
antonreshetov approved these changes Jan 9, 2019
View reviewed changes
Copy link
Owner

@antonreshetov antonreshetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks @alxwrd 👍

@antonreshetov antonreshetov merged commit 8f62ab5 into antonreshetov:master Jan 9, 2019
@alxwrd alxwrd deleted the reload-project branch January 9, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonreshetov antonreshetov antonreshetov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alxwrd @antonreshetov