Bug fixes for shortcut assistant layer #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xQwexx
force-pushed
the
fix/shortcut-layer
branch
from
975cd87
to
cfd8557
Compare
Signed-off-by: Alex <[email protected]>
xQwexx
force-pushed
the
fix/shortcut-layer
branch
from
cfd8557
to
0200530
Compare
|
This does indeed fix the altgr vs alt issue, but it is the same key on some layouts. Overall, i think it is worth it splitting up these keys, as users with 2 alt keys can get the same functionality by adding more shortcuts to the list. Drawing the background excluding the foreground makes sense to allow effects to shine through. |
diogotr7
approved these changes
Apr 4, 2020
This was referenced Apr 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes the following changes:
-Alt and Alt Gr triggers each other: For already existing layers reset needed to this fix to work.
-Dim the background keys without 'disabling' background effects
List any issues that this PR fixes: fixes # , etc...
"Fixes #1489 , and fixes #1571