Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use selected text as input to find-replace plugin #7

Closed
antoniolucasnobar opened this issue Apr 19, 2021 · 0 comments
Closed

Use selected text as input to find-replace plugin #7

antoniolucasnobar opened this issue Apr 19, 2021 · 0 comments
Assignees
@antoniolucasnobar

Comments

@antoniolucasnobar
Copy link
Owner

It is a common behavior the user selects some text and then CTRL+F to search for that term.
Most of search plugins detect and use the current selected text as the word the user wants to search.

One caveat. CKEditor allows to select different portions of text using CTRL. The plugin should only use the input if there is only one continuous selection.
@antoniolucasnobar antoniolucasnobar self-assigned this Jun 7, 2021
antoniolucasnobar pushed a commit that referenced this issue Jun 7, 2021
[#7] no need to use Array.from:
623a55f 
- getChildren is already an iterable and can be used in for loop;
- using 'text' and '$text' (changed in CKEditor5 v20);
- inline redundant variables.
antoniolucasnobar pushed a commit that referenced this issue Jun 7, 2021
[#7] update docs and images
368ea40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antoniolucasnobar antoniolucasnobar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@antoniolucasnobar