Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix allow synthetic default import #34

Conversation

NikolayBaranovv
Copy link
Contributor

Hello!
Current version of the library forces all users to enable allowSyntheticDefaultImports option in tsconfig. Without this option TypeScript breaks on import React from 'react', you should use import * as React from 'react'.

It's better not to force users to have non-default options in tsconfig.

@antonfisher antonfisher merged commit 234e052 into antonfisher:master Oct 13, 2021
@antonfisher
Copy link
Owner

Thanks 👍

@NikolayBaranovv
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants