Skip to content

Commit

Permalink
re enable Dual Mode tests listed in dotnet#1481
Browse files Browse the repository at this point in the history
  • Loading branch information
@antonfirsov
antonfirsov committed Feb 7, 2020
1 parent e2dafdf commit 477acf8
Showing 1 changed file with 12 additions and 33 deletions.
45 changes: 12 additions & 33 deletions src/libraries/System.Net.Sockets/tests/FunctionalTests/DualModeSocketTest.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,6 @@ public void Socket_ConnectV4IPAddressListToV4Host_Throws()
}

[Theory]
[PlatformSpecific(TestPlatforms.Windows)] // Binds to a specific port on 'connectTo' which on Unix may already be in use
[MemberData(nameof(DualMode_IPAddresses_ListenOn_DualMode_Throws_Data))]
public void DualModeConnect_IPAddressListToHost_Throws(IPAddress[] connectTo, IPAddress listenOn, bool dualModeServer)
{
Expand Down Expand Up @@ -800,7 +799,6 @@ public void BeginAcceptV6BoundToAnyV6_Success()
}

[Fact]
[PlatformSpecific(TestPlatforms.Windows)] // Binds to a specific port on 'connectTo' which on Unix may already be in use
public void BeginAcceptV6BoundToSpecificV4_CantConnect()
{
Assert.Throws<SocketException>(() =>
Expand All @@ -810,7 +808,6 @@ public void BeginAcceptV6BoundToSpecificV4_CantConnect()
}

[Fact]
[PlatformSpecific(TestPlatforms.Windows)] // Binds to a specific port on 'connectTo' which on Unix may already be in use
public void BeginAcceptV4BoundToSpecificV6_CantConnect()
{
Assert.Throws<SocketException>(() =>
Expand All @@ -820,7 +817,6 @@ public void BeginAcceptV4BoundToSpecificV6_CantConnect()
}

[Fact]
[PlatformSpecific(TestPlatforms.Windows)] // Binds to a specific port on 'connectTo' which on Unix may already be in use
public void BeginAcceptV6BoundToAnyV4_CantConnect()
{
Assert.Throws<SocketException>(() =>
Expand Down Expand Up @@ -906,7 +902,6 @@ public void AcceptAsyncV6BoundToAnyV6_Success()
}

[Fact]
[PlatformSpecific(TestPlatforms.Windows)] // Binds to a specific port on 'connectTo' which on Unix may already be in use
public void AcceptAsyncV6BoundToSpecificV4_CantConnect()
{
Assert.Throws<SocketException>(() =>
Expand All @@ -916,7 +911,6 @@ public void AcceptAsyncV6BoundToSpecificV4_CantConnect()
}

[Fact]
[PlatformSpecific(TestPlatforms.Windows)] // Binds to a specific port on 'connectTo' which on Unix may already be in use
public void AcceptAsyncV4BoundToSpecificV6_CantConnect()
{
Assert.Throws<SocketException>(() =>
Expand All @@ -926,7 +920,6 @@ public void AcceptAsyncV4BoundToSpecificV6_CantConnect()
}

[Fact]
[PlatformSpecific(TestPlatforms.Windows)] // Binds to a specific port on 'connectTo' which on Unix may already be in use
public void AcceptAsyncV6BoundToAnyV4_CantConnect()
{
Assert.Throws<SocketException>(() =>
Expand Down Expand Up @@ -1059,7 +1052,6 @@ public void SendToV6IPEndPointToV6Host_Success()
}

[Fact]
[PlatformSpecific(TestPlatforms.Windows)] // Binds to a specific port on 'connectTo' which on Unix may already be in use
public void SendToV4IPEndPointToV6Host_NotReceived()
{
Assert.Throws<TimeoutException>(() =>
Expand All @@ -1069,7 +1061,6 @@ public void SendToV4IPEndPointToV6Host_NotReceived()
}

[Fact]
[PlatformSpecific(TestPlatforms.Windows)] // Binds to a specific port on 'connectTo' which on Unix may already be in use
public void SendToV6IPEndPointToV4Host_NotReceived()
{
Assert.Throws<TimeoutException>(() =>
Expand Down Expand Up @@ -1280,7 +1271,6 @@ public void SendToAsyncV6IPEndPointToV6Host_Success()
}

[Fact]
[PlatformSpecific(TestPlatforms.Windows)] // Binds to a specific port on 'connectTo' which on Unix may already be in use
public void SendToAsyncV4IPEndPointToV6Host_NotReceived()
{
Assert.Throws<TimeoutException>(() =>
Expand All @@ -1290,7 +1280,6 @@ public void SendToAsyncV4IPEndPointToV6Host_NotReceived()
}

[Fact]
[PlatformSpecific(TestPlatforms.Windows)] // Binds to a specific port on 'connectTo' which on Unix may already be in use
public void SendToAsyncV6IPEndPointToV4Host_NotReceived()
{
Assert.Throws<TimeoutException>(() =>
Expand Down Expand Up @@ -1420,9 +1409,7 @@ public void ReceiveFromV6BoundToAnyV6_Success()
}

[Fact]
// Binds to a specific port on 'connectTo' which on Unix may already be in use
// Also ReceiveFrom not supported on OSX
[PlatformSpecific(TestPlatforms.Windows)]
[PlatformSpecific(~TestPlatforms.OSX)] // ReceiveFrom not supported on OSX
public void ReceiveFromV6BoundToSpecificV4_NotReceived()
{
Assert.Throws<SocketException>(() =>
Expand All @@ -1432,9 +1419,8 @@ public void ReceiveFromV6BoundToSpecificV4_NotReceived()
}

[Fact]
// Binds to a specific port on 'connectTo' which on Unix may already be in use
// Also expected behavior is different on OSX and Linux (ArgumentException instead of SocketException)
[PlatformSpecific(TestPlatforms.Windows)]
// Expected behavior is different on OSX and Linux(ArgumentException instead of SocketException)
[PlatformSpecific(~(TestPlatforms.Linux | TestPlatforms.OSX))]
public void ReceiveFromV4BoundToSpecificV6_NotReceived()
{
Assert.Throws<SocketException>(() =>
Expand All @@ -1444,9 +1430,7 @@ public void ReceiveFromV4BoundToSpecificV6_NotReceived()
}

[Fact]
// Binds to a specific port on 'connectTo' which on Unix may already be in use
// Also ReceiveFrom not supported on OSX
[PlatformSpecific(TestPlatforms.Windows)]
[PlatformSpecific(~TestPlatforms.OSX)] // ReceiveFrom not supported on OSX
public void ReceiveFromV6BoundToAnyV4_NotReceived()
{
Assert.Throws<SocketException>(() =>
Expand Down Expand Up @@ -1552,9 +1536,7 @@ public void BeginReceiveFromV6BoundToAnyV6_Success()
}

[Fact]
// Binds to a specific port on 'connectTo' which on Unix may already be in use
// Also BeginReceiveFrom not supported on OSX
[PlatformSpecific(TestPlatforms.Windows)]
[PlatformSpecific(~TestPlatforms.OSX)] // BeginReceiveFrom not supported on OSX
public void BeginReceiveFromV6BoundToSpecificV4_NotReceived()
{
Assert.Throws<TimeoutException>(() =>
Expand All @@ -1564,9 +1546,8 @@ public void BeginReceiveFromV6BoundToSpecificV4_NotReceived()
}

[Fact]
// Binds to a specific port on 'connectTo' which on Unix may already be in use
// Also expected behavior is different on OSX and Linux (ArgumentException instead of TimeoutException)
[PlatformSpecific(TestPlatforms.Windows)]
// Expected behavior is different on OSX and Linux (ArgumentException instead of TimeoutException)
[PlatformSpecific(~(TestPlatforms.Linux | TestPlatforms.OSX))]
public void BeginReceiveFromV4BoundToSpecificV6_NotReceived()
{
Assert.Throws<TimeoutException>(() =>
Expand All @@ -1576,9 +1557,7 @@ public void BeginReceiveFromV4BoundToSpecificV6_NotReceived()
}

[Fact]
// Binds to a specific port on 'connectTo' which on Unix may already be in use
// Also BeginReceiveFrom not supported on OSX
[PlatformSpecific(TestPlatforms.Windows)]
[PlatformSpecific(~TestPlatforms.OSX)] // BeginReceiveFrom not supported on OSX
public void BeginReceiveFromV6BoundToAnyV4_NotReceived()
{
Assert.Throws<TimeoutException>(() =>
Expand Down Expand Up @@ -1912,7 +1891,7 @@ public void ReceiveMessageFromV6BoundToAnyV6_Success()
}

[Fact]
[PlatformSpecific(TestPlatforms.Windows)] // Binds to a specific port on 'connectTo' which on Unix may already be in use; ReceiveMessageFrom not supported on OSX
[PlatformSpecific(~TestPlatforms.OSX)] // ReceiveMessageFrom not supported on OSX
public void ReceiveMessageFromV6BoundToSpecificV4_NotReceived()
{
Assert.Throws<SocketException>(() =>
Expand All @@ -1922,7 +1901,7 @@ public void ReceiveMessageFromV6BoundToSpecificV4_NotReceived()
}

[Fact]
[PlatformSpecific(TestPlatforms.Windows)] // Binds to a specific port on 'connectTo' which on Unix may already be in use; ReceiveMessageFrom not supported on OSX
[PlatformSpecific(~(TestPlatforms.Linux | TestPlatforms.OSX))] // Expected behavior is different on OSX and Linux
public void ReceiveMessageFromV4BoundToSpecificV6_NotReceived()
{
Assert.Throws<SocketException>(() =>
Expand All @@ -1932,7 +1911,7 @@ public void ReceiveMessageFromV4BoundToSpecificV6_NotReceived()
}

[Fact]
[PlatformSpecific(TestPlatforms.Windows)] // Binds to a specific port on 'connectTo' which on Unix may already be in use; ReceiveMessageFrom not supported on OSX
[PlatformSpecific(~TestPlatforms.OSX)] // ReceiveMessageFrom not supported on OSX
public void ReceiveMessageFromV6BoundToAnyV4_NotReceived()
{
Assert.Throws<SocketException>(() =>
Expand Down Expand Up @@ -2731,4 +2710,4 @@ protected void ReceiveFrom_Helper(IPAddress listenOn, IPAddress connectTo)
}
}
}
}
}

0 comments on commit 477acf8

Please sign in to comment.