fix(terraform_docs): Fix issue with processing multiply files without terraform-docs markers. Issue introduced in v1.95.0

[ryan-at-ld]

Put an x into the box if that apply:

• This PR introduces breaking change.
• This PR fixes a bug.
• This PR adds new functionality.
• This PR enhances existing functionality.

Description of your changes

A bug in the terraform-docs hook was introduced in #717. In that PR, a continue statement was added that is not preceded by a popd command. The bug is only triggered when the hook is processing multiple files where one (or more) of the files does not contain the terraform-docs marker statements. The hook fails to process the remaining files because the working directory is not reset to the root of the repository. I ran into this bug on version 1.96.0 of the hooks and pre-commit version 3.8.0.

How can we test changes

Here is a script to reproduce the issue. It creates a repository containing multiple modules. The pre-commit run -a command will print an error similar to ~/.cache/pre-commit/reporqzucglw/hooks/terraform_docs.sh: line 178: pushd: modules/c: No such file or directory and module C's README won't be updated by terraform-docs.

cat <<EOF> .pre-commit-config.yaml
---
repos:
  - repo: https://github.com/antonbabenko/pre-commit-terraform
    rev: v1.96.0
    hooks:
      - id: terraform_docs
        files: '.*'
        verbose: true
        types_or:
          - markdown
          - terraform
EOF

git init
pre-commit install --install-hooks
mkdir -p modules/{a,b,c}

cat <<EOF> modules/a/README.md
# I'm module A

<!-- BEGIN_TF_DOCS -->
<!-- END_TF_DOCS -->

EOF

cat <<EOF> modules/b/README.md
# I'm module B

I break things

EOF

cat <<EOF> modules/c/README.md
# I'm module C

<!-- BEGIN_TF_DOCS -->
<!-- END_TF_DOCS -->

EOF

git add .
pre-commit run -a

[yermulnik]

Great catch. Thank you 👍🏻

[yermulnik]

@MaxymVlasov Would you please add second pair of eyes?

[MaxymVlasov]

Thank you

[antonbabenko]

This PR is included in version 1.96.1 🎉