Skip to content

Commit

Permalink
Added note about incompatibility of terraform-docs with Terraform 0.12 (
Browse files Browse the repository at this point in the history
  • Loading branch information
antonbabenko authored May 27, 2019
1 parent 418a5ec commit 5725b11
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: git://github.com/pre-commit/pre-commit-hooks
rev: v2.0.0
rev: v2.2.3
hooks:
- id: check-yaml
- id: end-of-file-fixer
Expand Down
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ Step into the repository you want to have the pre-commit hooks installed and run
```bash
cat <<EOF > .pre-commit-config.yaml
- repo: git://github.com/antonbabenko/pre-commit-terraform
rev: v1.11.0
rev: v1.12.0
hooks:
- id: terraform_fmt
- id: terraform_docs
# - id: terraform_docs # terraform-docs is not working with Terraform 0.12 yet (read note in README)
EOF
```

Expand Down Expand Up @@ -73,6 +73,8 @@ Check the [source file](https://github.com/antonbabenko/pre-commit-terraform/blo
1. It is possible to pass additional arguments to shell scripts when using `terraform_docs` and `terraform_docs_without_aggregate_type_defaults`. Send pull-request with the new hook if there is something missing.

1. `terraform-docs` is not working with Terraform 0.12 yet (see [issue #62](https://github.com/segmentio/terraform-docs/issues/62)), so remember to disable `terraform_docs`, `terraform_docs_replace` and `terraform_docs_without_aggregate_type_defaults` hooks in your `.pre-commit-config.yaml`

## Notes for developers

1. Python hooks are supported now too. All you have to do is:
Expand Down

0 comments on commit 5725b11

Please sign in to comment.