-
Notifications
You must be signed in to change notification settings - Fork 71
Hash gzipped files if AWS_IS_GZIPPED is True #108
Conversation
Filed a PR in django-storages to fix the mtime in Update: The PR has merged. |
This should be ready for review. |
@antonagestam any chance you could review this? I would love to get this in my project as things are really slow without it. thanks! |
Sorry, I'm not going to review any pull requests on this project until I get an indication from the roadies what their thoughts are on this jazzband/help#72 |
@antonagestam I 100% agree with you on having a process around contribution. It kind of sucks to have people committing code, free from any review, to master. That being said, I hope you'd be willing to reconsider not reviewing PRs as I feel like that only bolsters the notion that having a process like review of pull requests is tedious and holds up development. |
I apologize for requesting your review. I requested your review of the PR since it's your repository and you were involved with the original issue. Hopefully I didn't step on any toes. A process with guidelines would be ideal. In any case, I hope you get everything sorted out! |
@rehandalal How is the performance of this looking in your tests? Also, is the gzipping deterministic so that it generates the same zipped content locally as it will for amazon remotely? |
This is now published in the 0.6.0 release. Thank you again for the contribution! |
Thanks for publishing this. To answer your questions:
|
Fixes #46.
This is a WIP but submitting for feedback.