Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(preimage): Traces #13

Merged
merged 2 commits into from
Sep 23, 2023
Merged

feat(preimage): Traces #13

merged 2 commits into from
Sep 23, 2023

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Sep 23, 2023 •
edited
Loading

Description

Introduces tracing convenience macros to the preimage crate under the tracing feature flag.

Fixes #12

@refcell refcell requested a review from clabby September 23, 2023 20:12
@refcell refcell self-assigned this Sep 23, 2023
@refcell refcell marked this pull request as draft September 23, 2023 20:12
@refcell refcell marked this pull request as ready for review September 23, 2023 22:23
clabby
clabby approved these changes Sep 23, 2023
View reviewed changes
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, love the convenience macros to not spam feature flags everywhere 😄

@clabby clabby merged commit b65838d into main Sep 23, 2023
4 checks passed
@clabby clabby deleted the refcell/traces branch September 23, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

Assignees

@refcell refcell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Tracing
2 participants
@refcell @clabby