Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MaxAbsScaler for some Multiplicative Signal Transformations #235

Closed
antoinecarme opened this issue Mar 24, 2023 · 1 comment
Closed

Comments

@antoinecarme
Copy link
Owner

antoinecarme commented Mar 24, 2023

PyAF uses a MinMaxScaler for all transformations by default. This introduces zero values in the scaled signal.

https://scikit-learn.org/stable/modules/generated/sklearn.preprocessing.MinMaxScaler.html#sklearn.preprocessing.MinMaxScaler

image

Multiplicative transformations (RelativeDifference, BoxCox) should work better by using a MaxAbsScaler whic his more adapted for positive signals.

https://scikit-learn.org/stable/modules/generated/sklearn.preprocessing.MaxAbsScaler.html#sklearn.preprocessing.MaxAbsScaler

image

@antoinecarme
Copy link
Owner Author

This "feature" was introduced when twaeking PyAf 5.0-Fixes branck. A commit is already made :

9420fc6

image

This issue was created to keep track of this significant change as a part of another issue :

#234

@antoinecarme antoinecarme changed the title Use MaxAbsScaler for some Multiplicative Signal Tranformations Use MaxAbsScaler for some Multiplicative Signal Transformations Mar 24, 2023
@antoinecarme antoinecarme self-assigned this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant