Skip to content

Commit

Permalink
Use MASE by default for PyAF Model Selection #229. Corrected RMSSE co…
Browse files Browse the repository at this point in the history
…mputations.
  • Loading branch information
antoinecarme committed Mar 13, 2023
1 parent 2e57b50 commit 5b9c8ff
Showing 1 changed file with 11 additions and 8 deletions.
19 changes: 11 additions & 8 deletions pyaf/TS/Perf.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,14 @@ def pre_compute_naive_mean_abs_error_ratio_if_needed(self, signal , estimator):
return cached_result
abs_error = self.pre_compute_abs_error_if_needed(signal , estimator);
naive_error = signal - signal.shift(1)
naive_error = naive_error[1:]
lEps = 1.0e-10;
naive_mean_abs_error = np.mean(abs(naive_error.values[1:])) + lEps
q = np.abs(abs_error / naive_mean_abs_error)
self.mCachedValues['naive_scaled_error'] = q
return q
naive_mean_abs_error = np.mean(abs(naive_error)) + lEps
naive_mean_abs_error_2 = np.mean(abs(naive_error * naive_error)) + lEps
q1 = np.abs(abs_error / naive_mean_abs_error)
q2 = np.abs(abs_error * abs_error / naive_mean_abs_error_2)
self.mCachedValues['naive_scaled_error'] = (q1, q2)
return (q1, q2)

def compute_MAPE(self, signal , estimator):
lEps = 1.0e-10;
Expand All @@ -103,13 +106,13 @@ def compute_SMAPE(self, signal , estimator):
self.mSMAPE = round( self.mSMAPE , 4 )

def compute_MASE(self, signal , estimator):
q = self.pre_compute_naive_mean_abs_error_ratio_if_needed(signal , estimator)
self.mMASE = np.mean(q)
(q1, q2) = self.pre_compute_naive_mean_abs_error_ratio_if_needed(signal , estimator)
self.mMASE = np.mean(q1)
self.mMASE = round( self.mMASE , 4 )

def compute_RMSSE(self, signal , estimator):
q = self.pre_compute_naive_mean_abs_error_ratio_if_needed(signal , estimator)
self.mRMSSE = np.sqrt(np.mean(q * q))
(q1, q2) = self.pre_compute_naive_mean_abs_error_ratio_if_needed(signal , estimator)
self.mRMSSE = np.sqrt(np.mean(q2))
self.mRMSSE = round( self.mRMSSE , 4 )

def compute_DiffSMAPE(self, signal , estimator):
Expand Down

0 comments on commit 5b9c8ff

Please sign in to comment.