[postgresql] Fix for #4306 -- ambiguity in target_el #4307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #4306.
Consider input
select x || y from collate_test10;
. This substringx || y
, can be parsed two ways:target_el
=>a_expr identifier
==>x ||
y
.target_el
=>a_expr
==>a_expr_qual_op
=>a_expr_unary_qualop qual_op a_expr_unary_qualop
==>x || y
. This is the likely preferred derivation.The fix is to add a semantic predicate before an alt in the rule
a_expr_qual
, which specifies the syntax for a unary postfix operator. Only!
and!!
should be allowed.However, PostgreSQL allows new operators to be declared. This will need to be fixed later on.