Pulled in previous JavaScript grammar improvements into TypeScript grammar. #3973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript is a (typed) superset of the JavaScript language and there have been many improvements to the JavaScript grammar that haven't made it into the TypeScript grammar. This PR pulls them in, and adds a couple of minor TypeScript only improvements.
Improvements to the TypeScript grammar from the existing JavaScript grammar include:
**
,**=
) and coalescing (??
,??=
) operators.The TypeScript specific improvements are:
Promise<Map<string, Set<string>>>
now works.catch (error: MyError) {
I've copied a couple of the JavaScript examples to the TypeScript example directory to help test the improvements. It would be nice if the TypeScript tests made sure we could parse all of the JavaScript examples. However without copying all the files, I wasn't sure how to do that (and whether the intention was to deliberately decouple each language).
To review it might make sense to look at the diff TypeScriptParser.g4 with JavaScriptParser.g4 (ditto for lexers) as most of the changes are just existing grammar.
There is still more work to be done to bring Typescript up to date.