Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Cleanup ATNDeserializer and remove related deprecated methods from ATNSimulator #3545

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

jcking
Copy link
Collaborator

@jcking jcking commented Feb 17, 2022

Simple cleanup of ATNDeserializer that removes virtual methods, since they cannot really be overridden anyway, moves private methods to the source file, and removes related deprecated methods from ATNSimulator since nobody should be using those.

@jcking
Copy link
Collaborator Author

jcking commented Feb 17, 2022

@mike-lischke

Copy link
Member

@mike-lischke mike-lischke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcking I wish you would not shuffle around so much code. That removes the pieces from their surrounding context and is difficult to review. If I didn't miss anything then I think this patch is ok, however.

@parrt This patch is ready for merge.

@parrt parrt added this to the 4.10 milestone Feb 21, 2022
@parrt
Copy link
Member

parrt commented Feb 21, 2022

two of the tests fail but I think it has something to do with the continuous integration server.

@parrt parrt merged commit f5f777d into antlr:dev Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants