Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser fs fallback #3414

Merged
merged 2 commits into from
Dec 28, 2021
Merged

Conversation

Ketler13
Copy link
Contributor

@Ketler13 Ketler13 commented Dec 16, 2021

This is an attempt to fix runtime browser issue - #2852 for environments like create-react-app where there is no possibility to manipulate webpack config without ejecting the application. I did this locally for installed antlr4 package and it helped me. Hope this solution is good enough.

Please also read webpack 5 migration notes :
Package authors: Use the browser field in package.json to make a package frontend-compatible. Provide alternative implementations/dependencies for the browser.

Ignore module in package.json

Thank you for the great tool!

@ericvergnaud
Copy link
Contributor

@parrt blessed

@parrt parrt added this to the 4.9.4 milestone Dec 28, 2021
@parrt parrt merged commit 5b8390b into antlr:master Dec 28, 2021
@MarkDGithub
Copy link

I am having the same issue, any idea when we might expect an updated npm package with the merged changes?

@parrt
Copy link
Member

parrt commented Jan 30, 2022

We are actually doing quite a number of important changes so I don't have a date for you but I'm hoping within a month or so we can get 4.10 out the door.

@MattNot
Copy link

MattNot commented Mar 24, 2022

Any news for this to be added in a release?

@parrt
Copy link
Member

parrt commented Mar 24, 2022

Finally got in major changes that I needed to make so I will start the release process over the next weak or two. sorry for the delay. This has been merged so it will show up in the release 4.10

@parrt
Copy link
Member

parrt commented Mar 24, 2022

(It's in dev branch now if you'd like to try out)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants