Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Cleanup EMPTY_VOCABULARY uses and remove SingleWriteMultipleRea… #3400

Merged
merged 2 commits into from
Dec 13, 2021

Conversation

jcking
Copy link
Collaborator

@jcking jcking commented Dec 9, 2021

No description provided.

@jcking
Copy link
Collaborator Author

jcking commented Dec 9, 2021

@mike-lischke

@mike-lischke
Copy link
Member

@parrt Another C++ patch ready for merge.

@parrt parrt added this to the 4.9.4 milestone Dec 11, 2021
@parrt
Copy link
Member

parrt commented Dec 11, 2021

@mike-lischke could you guys resolve the conflict? thanks!

@jcking
Copy link
Collaborator Author

jcking commented Dec 11, 2021 via email

@jcking
Copy link
Collaborator Author

jcking commented Dec 13, 2021

Fixed conflict.

@mike-lischke
Copy link
Member

@jcking Thanks!

@parrt The C++ parser tests just take too long and always time out now, it seems :-( At least this is what CircleCI says. Github actions just have a red cross saying the action failed (not exactly helping...).

Otherwise the patch looks fine for merge.

@KvanTTT
Copy link
Member

KvanTTT commented Dec 13, 2021

Is it possible to improve the performance of C++ compilation by any way? I've noticed it's slow on my local machine as well.

Also, maybe it makes sense to request a more advanced tariff plan for ANTLR project for free because it's valuable and free project.

@mike-lischke
Copy link
Member

mike-lischke commented Dec 13, 2021

It's slow because it does the worst thing you can do to a C++ project: frequent rebuilds. That's not an issue with script languages or more modern languages. Improving that would require to restructure the way the tests run, which at the time I suggested that the last time wasn't really an option.

A better tariff would certainly help.

@KvanTTT
Copy link
Member

KvanTTT commented Dec 13, 2021

Improving that would require to restructure the way the tests run

Yes, something like that. I can imagine how it could work for C# (the second slowest language after C++ but even so much faster): use dynamic compilation, but can not for C++.

@parrt
Copy link
Member

parrt commented Dec 13, 2021

I am thinking about rebuilding the test rig so I will split apart the parsing test so that C++ can pass.

@parrt parrt merged commit 01a3280 into antlr:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants