Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Fix ambiguous ANTLRInputStream constructor overload #3394

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

jcking
Copy link
Collaborator

@jcking jcking commented Dec 6, 2021

Not sure when this was added, but std::string is implicitly convertible to std::string_view. So this can cause compilation errors as the compiler does not know which one to select.

@jcking
Copy link
Collaborator Author

jcking commented Dec 6, 2021

@parrt Compilation fix. std::string is implicitly convertible to std::string_view. So the current code causes the compiler to be confused when using something like a string literal.

@parrt parrt added this to the 4.9.4 milestone Dec 6, 2021
@parrt parrt merged commit 261769f into antlr:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants