[C++] Modernize Vocabulary using std::string_view #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcking
force-pushed
the
cpp-vocab-string-view
branch
6 times, most recently
from
14881d6
to
809b8df
Compare
jcking
force-pushed
the
cpp-vocab-string-view
branch
from
809b8df
to
0d6263a
Compare
mike-lischke
reviewed
Dec 5, 2021
mike-lischke
approved these changes
Dec 7, 2021
|
@parrt A C++ patch ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
Vocabularyto usestd::string_viewwhere possible. This is part 1 of multiple patches which will migrate most uses to std::string_view where possible for generated grammars.