Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3126 #3130

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Fix 3126 #3130

merged 2 commits into from
Mar 19, 2021

Conversation

ericvergnaud
Copy link
Contributor

No description provided.

@ericvergnaud ericvergnaud changed the title Fix 3216 Fix 3126 Mar 18, 2021
@ericvergnaud
Copy link
Contributor Author

Fixes #3126

@ericvergnaud
Copy link
Contributor Author

@pboyer @jwkohnen would you ming checking the consistent failure of the go build on AppVeyor for the last week?
I suspect it could be caused by:
private static final String GO_RUNTIME_IMPORT_PATH = "github.com/antlr/antlr4/runtime/Go/antlr"; // TODO: Change this before merging with upstream
but would rather let you opine

@ericvergnaud ericvergnaud merged commit 3590d4d into master Mar 19, 2021
@ericvergnaud ericvergnaud mentioned this pull request Mar 22, 2021
Closed
@ericvergnaud ericvergnaud deleted the fix-3216 branch September 28, 2021 09:18
@parrt parrt added this to the 4.9.3 milestone Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.9.3
Development

Successfully merging this pull request may close these issues.
2 participants
@ericvergnaud @parrt