Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character issues #1517

Closed
wants to merge 6 commits into from
Closed

Character issues #1517

wants to merge 6 commits into from

Conversation

KvanTTT
Copy link
Member

@KvanTTT KvanTTT commented Dec 15, 2016

fixed #1077 and another character issues (see tests for detail).
Some changes are taken from #1092

@mike-lischke
Copy link
Member

While you are that would it be possible for you to add full Unicode sets (everything up to 0x10FFFF) in the code generator? That looks like something related to your changes here, so you might have a quick idea how to implement that.

@parrt
Copy link
Member

parrt commented Dec 15, 2016

There's a lot going on here. Not sure I can make all of these right before a release. E.g., I don't agree that 'keyword' and ID should yield a warning. we'll see millions of them in a typical grammar.

@KvanTTT
Copy link
Member Author

KvanTTT commented Dec 15, 2016

@mike-lischke I think full Unicode sets should be implemented in separated pull request. This one it too big and fixes the bugs, not brings a new features.

@KvanTTT
Copy link
Member Author

KvanTTT commented Dec 15, 2016

E.g., I don't agree that 'keyword' and ID should yield a warning

@parrt 'keyword' and ID does not yield a warning here. This PR about incorrect (reversed), duplicated and empty char sets.

@parrt
Copy link
Member

parrt commented Dec 15, 2016

ah. ok, well, let me pull and sniff some more. still makes me nervous.

@parrt
Copy link
Member

parrt commented Dec 15, 2016

@mike-lischke I don't see a quick way to do 32-bit unicode. certainly makes everything hard as char is 16 bits in Java.

@parrt
Copy link
Member

parrt commented Dec 15, 2016

@KvanTTT please note for future reference how i like my else on a separate line than } ;) Ah. actually, that looks like it was somebody else. oh well. fixing. :)

@KvanTTT
Copy link
Member Author

KvanTTT commented Dec 15, 2016

@parrt ok, I got it :)

@parrt
Copy link
Member

parrt commented Dec 15, 2016

I pulled in your stuff into a separate branch, made some tweaks and will use a separate PR so I'm closing this.

@parrt parrt closed this Dec 15, 2016
@KvanTTT KvanTTT deleted the character_issues branch December 15, 2016 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ANTLR4 problem with malformed(?) backslash-specified unicode literal
3 participants