-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Character issues #1517
Character issues #1517
Conversation
EMPTY_STRINGS_NOT_ALLOWED rename to EMPTY_STRINGS_AND_SETS_NOT_ALLOWED.
Implemented EMPTY_STRINGS_AND_SETS_NOT_ALLOWED for empty sets. Improved INVALID_ESCAPE_SEQUENCE, fixes antlr#1077
…TRINGS_AND_SETS_NOT_ALLOWED.
While you are that would it be possible for you to add full Unicode sets (everything up to 0x10FFFF) in the code generator? That looks like something related to your changes here, so you might have a quick idea how to implement that. |
There's a lot going on here. Not sure I can make all of these right before a release. E.g., I don't agree that 'keyword' and ID should yield a warning. we'll see millions of them in a typical grammar. |
@mike-lischke I think full Unicode sets should be implemented in separated pull request. This one it too big and fixes the bugs, not brings a new features. |
@parrt 'keyword' and ID does not yield a warning here. This PR about incorrect (reversed), duplicated and empty char sets. |
ah. ok, well, let me pull and sniff some more. still makes me nervous. |
@mike-lischke I don't see a quick way to do 32-bit unicode. certainly makes everything hard as char is 16 bits in Java. |
@KvanTTT please note for future reference how i like my |
@parrt ok, I got it :) |
I pulled in your stuff into a separate branch, made some tweaks and will use a separate PR so I'm closing this. |
fixed #1077 and another character issues (see tests for detail).
Some changes are taken from #1092