Preparing for 4.9.3 release #3301

parrt · 2021-10-11T18:27:49Z

It's that time of year again! @pboyer, @mike-lischke, @janyou, @ewanmellor, @hanjoes, @ericvergnaud, @lingyv-li, @marcospassos Shall we do a 4.9.3 release?

I went through and marked all of the merged PRs and related issues with 4.9.3 and try to tag them according to their target. Would you guys like to go through the PRs to see if there's something that should be merged quickly?

KvanTTT · 2021-10-11T18:33:45Z

This one can be merged: #3211

parrt · 2021-10-11T18:38:39Z

Thanks, @KvanTTT I was just going to add you to this participant list...merged.

hanjoes · 2021-10-11T18:57:09Z

here is a list of PRs related, not sure if i'm missing out anything: https://github.com/antlr/antlr4/pulls?q=is%3Apr+is%3Aopen+swift
#3025 #3026 #3098 #3099 seem fine to be merged
#3132 is related to #1771 where you folks seem to have had a massive discussion .. will need to take a look later in the day.

parrt · 2021-10-11T20:02:31Z

Ok, I merged all those except #3132. thanks!

lingyv-li · 2021-10-11T22:03:56Z

yay!
#3119 #3245 #3246 #3247 #3253 should be ready to be merged.
#3191 can be closed (without merging) as it's achieved by #3250

ericvergnaud · 2021-10-12T09:19:07Z

All good here, nothing to merge for C#, Javascript, Python2 or Python3

mike-lischke · 2021-10-12T10:02:01Z

I have nothing (to my knowledge) that would need to be merged yet for this release (regarding the C++ target).

btw. would it be possible to notify target owners when an issue or PR is posted and tagged with a language? Or some other kind of notification?

parrt · 2021-10-14T16:56:46Z

@mike-lischke I try to add the target label as I merge PRs and close bugs.

@lingyv-li ok, I have merged all of those you mentioned!

thanks guys!

parrt · 2021-10-14T17:01:02Z

@hanjoes it looks like the swift target is failing. can you take a look at the error message? https://github.com/antlr/antlr4/runs/3863274808?check_suite_focus=true

Actually Swift just ran through all the tests on my local machine no problem so we can call it good.

parrt · 2021-10-14T17:07:21Z

I don't think we use travis anymore right for continuous integration? https://app.travis-ci.com/github/antlr/antlr4 so maybe we should take off the badge from the readme?

parrt · 2021-10-14T17:13:50Z

Ok, I will wait to hear from people but it sounds like we've merged everything and I can start the release process...

ericvergnaud · 2021-10-14T17:26:50Z

We do for Swift/Linux which I could not get running on CircleCI But unfortunately we kill our OSS credit so rapidly that we never get a chance to see a green build Sugest we ignore it for now, until I can invest time in CircleCI

…

Le 14 oct. 2021 à 19:07, Terence Parr ***@***.***> a écrit : I don't think we use travis anymore right for continuous integration? https://app.travis-ci.com/github/antlr/antlr4 <https://app.travis-ci.com/github/antlr/antlr4> so maybe we should take off the badge from the readme? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3301 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZNQJCVNAGRW4DEN7KZRCLUG4E5LANCNFSM5FY2DH4Q>.

lambersond · 2021-10-14T18:32:04Z

Will this update fix the CVE-2020-21913 Vulnerability? It looks like there was an open PR trying to fix this. However, it wasn't passing all tests.

mike-lischke · 2021-10-15T07:35:32Z

@mike-lischke I try to add the target label as I merge PRs and close bugs.

I'm afraid that won't help. We'd need a notification when a new bug or PR comes in for a particular target language. I hoped there would be a setting to do that, but I didn't find anything.

marcospassos · 2021-10-15T14:05:09Z

@parrt apparently, we need to fix this issue before releasing. I'm taking a look at this.

KvanTTT · 2021-10-17T19:59:28Z

Some important fixes: #3310 Also, I would like to fix this one #2006

marcospassos · 2021-10-18T12:15:17Z

On the PHP side, we're ready to go IMHO.

ericvergnaud · 2021-10-20T13:21:29Z

The Travis CI for Swift/Linux is back, and there are compilation errors such as:

/home/travis/build/antlr/antlr4/runtime/Swift/Tests/Antlr4Tests/ThreadingTests.swift:26:27: error: variable used within its own initial value

    let expectation = expectation(description: "Waiting on async-task")

can someone from the Swift target check ?

parrt · 2021-10-22T18:41:56Z

@hanjoes Could you take a peek?

kaby76 · 2021-10-22T20:20:27Z

I would recommend this change for the Go target (#3284), which fixes 3254--implementing a super class for a lexer for the Go target. Just today there was a question on StackOverflow asking why the Python3 grammar in grammars-v4 doesn't have a Go port. In order to implement the Go target, I'd have to write yet another @lexer::members fork of the Python4Lexer.g4 grammar. I'm willing to port the lexer base class to Go, but I'd really prefer to not write an @lexer::members fork, unless there somehow is a way to use @members in one grammar file for all 8 targets. You only have to look in the directory just above that grammar (https://github.com/antlr/grammars-v4/tree/master/python) to see the maintenance nightmare with uncontrolled forking of the grammar.

parrt · 2021-10-22T21:44:30Z

@kaby76 merged!

parrt · 2021-10-24T22:12:33Z

Yay, looks like Swift is passing now. https://github.com/antlr/antlr4/actions/runs/1375420432

parrt · 2021-10-27T22:06:32Z

it looks like tests are passing locally that I can test...swift/php/javascript I don't think I can test locally.

kaby76 · 2021-10-27T22:30:09Z

I'll try the grammars-v4 on the JavaScript target (and also CSharp, Java, Dart, Go) and see how it all works. I disabled the JavaScript target in the CI a few months ago because many grammars were failing to build (because target-specific code was not ported to another target) or run (crashes, un-terminating, or just plain parse errors). I'm psyched to see the fixes.

kaby76 · 2021-10-28T12:10:48Z

Much, much improved with JavaScript. Many more grammars now work (so far that I've checked, antlr/antlr2, basic, c, java/java, javascript/javascript). Ty @ericvergnaud ! One regression in the Antlr tool: it doesn't accept Graphemes.g4, whereas it did with 4.9.2 (Graphemes.g4:15:4: string literals and sets cannot be empty: [], haven't debugged it yet). The grammar has problems because it does try to use a fragment in a parser rule.

ericvergnaud · 2021-10-31T19:28:51Z

Eerrr not sure why you’re fetching snapshot artifacts from nexus or maven ? Envoyé de mon iPhone

…

Le 31 oct. 2021 à 17:48, Terence Parr ***@***.***> a écrit : Merged PRs as indicated by @mike-lischke; nexus still appears to be down: Failed to retrieve remote metadata org.antlr:antlr4-master:4.9.3-SNAPSHOT/maven-metadata.xml — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

parrt · 2021-10-31T19:36:44Z

I’m just following the exact same procedure that I always follow according to my documentation

ericvergnaud · 2021-10-31T23:01:15Z

Can you share that procedure ? Envoyé de mon iPhone

…

Le 31 oct. 2021 à 20:36, Terence Parr ***@***.***> a écrit : I’m just following the exact same procedure that I always follow according to my documentation — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

parrt · 2021-10-31T23:11:29Z

https://github.com/antlr/antlr4/blob/master/doc/releasing-antlr.md

ericvergnaud · 2021-10-31T23:31:22Z

Looks reasonable Seems there was something wrong à few hours ago: https://status.maven.org/ Envoyé de mon iPhone

…

Le 1 nov. 2021 à 00:11, Terence Parr ***@***.***> a écrit : https://github.com/antlr/antlr4/blob/master/doc/releasing-antlr.md — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

parrt · 2021-11-01T00:08:10Z

Something has changed. mvn -DskipTests=True deploy still gives same error I'm afraid.

parrt · 2021-11-01T20:07:48Z

Hi. @ericvergnaud thinks we've somehow gotten sonatype/nexus in a bad state. Should I change 4.9.3 to 4.9.4, skipping 4.9.3? It'll be a huge hassle to tweak all tagged issues/PRs...anybody know mvn/nexus that can help with the stupid error we're getting?

parrt · 2021-11-03T21:35:48Z

Hmm...maybe 4.9.3-1-SNAPSHOT...can't find a way to wipe the sonatype/nexus thing. Grrr...any help appreciated.

parrt · 2021-11-03T21:58:41Z

I have this .m2/settings.xml stuff which always used to work:

   <servers>
        <server>
          <id>sonatype-nexus-staging</id>
          <username>x</username>
          <password>xx</password>
        </server>
        <server>
          <id>sonatype-nexus-snapshots</id>
          <username>x</username>
          <password>xx</password>
        </server>
   </servers>

parrt · 2021-11-03T22:21:41Z

Ok, i blasted ~/.m2/repositories and now I can't even build:

[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for org.antlr:antlr4-master:4.9.3-SNAPSHOT: Could not transfer artifact org.sonatype.oss:oss-parent:pom:9 from/to central (https://repo.maven.apache.org/maven2): transfer failed for https://repo.maven.apache.org/maven2/org/sonatype/oss/oss-parent/9/oss-parent-9.pom and 'parent.relativePath' points at wrong local POM @ line 9, column 10
 @ 
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]   
[ERROR]   The project org.antlr:antlr4-master:4.9.3-SNAPSHOT (/Users/parrt/antlr/code/antlr4/pom.xml) has 1 error
[ERROR]     Non-resolvable parent POM for org.antlr:antlr4-master:4.9.3-SNAPSHOT: Could not transfer artifact org.sonatype.oss:oss-parent:pom:9 from/to central (https://repo.maven.apache.org/maven2): transfer failed for https://repo.maven.apache.org/maven2/org/sonatype/oss/oss-parent/9/oss-parent-9.pom and 'parent.relativePath' points at wrong local POM @ line 9, column 10: Received fatal alert: protocol_version -> [Help 2]

here is the parent:

	<parent>
		<groupId>org.sonatype.oss</groupId>
		<artifactId>oss-parent</artifactId>
		<version>9</version>
	</parent>

Do i need to change the version?

parrt · 2021-11-03T22:23:39Z

Intellij reports this for sync'ing with repo:

[ERROR] org.apache.maven.model.resolution.UnresolvableModelException: Failure to transfer org.sonatype.oss:oss-parent:pom:9 from https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced. Original error: Could not transfer artifact org.sonatype.oss:oss-parent:pom:9 from/to central (https://repo.maven.apache.org/maven2): transfer failed for https://repo.maven.apache.org/maven2/org/sonatype/oss/oss-parent/9/oss-parent-9.pom
[ERROR] Maven server structure problem

not even mvn clean works. haha

parrt · 2021-11-03T22:27:14Z

Maybe it's the "https" vs "http" thing that became popular this year?

parrt · 2021-11-03T22:27:58Z

Anyway, i guess no 4.9.3 release as I can't figure it out. PhDs aren't as useful as they used to be I guess haha

ericvergnaud · 2021-11-04T08:15:14Z

You sure you don’t want me to give it a try ? I don’t have a PhD, so that might help ;-)

…

Le 3 nov. 2021 à 23:28, Terence Parr ***@***.***> a écrit : Anyway, i guess no 4.9.3 release as I can't figure it out. PhDs aren't as useful as they used to be I guess haha — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3301 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZNQJCGZ6ZZJEM2AQYTBADUKHAQTANCNFSM5FY2DH4Q>.

parrt · 2021-11-04T16:51:14Z

Sure! Tell me how to give you sonatype permissions! A real programmer like you might be able to make this work!! :)

On Thu, Nov 4, 2021 at 1:15 AM ericvergnaud ***@***.***> wrote: You sure you don’t want me to give it a try ? I don’t have a PhD, so that might help ;-) > Le 3 nov. 2021 à 23:28, Terence Parr ***@***.***> a écrit : > > > Anyway, i guess no 4.9.3 release as I can't figure it out. PhDs aren't as useful as they used to be I guess haha > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub < #3301 (comment)>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAZNQJCGZ6ZZJEM2AQYTBADUKHAQTANCNFSM5FY2DH4Q >. > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3301 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABLUWOYP7BSKQ75FVLCRQDUKI6J5ANCNFSM5FY2DH4Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Dictation in use. Please excuse homophones, malapropisms, and nonsense.

hanjoes · 2021-11-04T16:55:29Z

Yay, looks like Swift is passing now. https://github.com/antlr/antlr4/actions/runs/1375420432

@parrt @ericvergnaud sorry was carried away by life/work. Glad it's solved now!

ericvergnaud · 2021-11-04T18:13:01Z

Let me check that

…

Le 4 nov. 2021 à 17:51, Terence Parr ***@***.***> a écrit : Sure! Tell me how to give you sonatype permissions! A real programmer like you might be able to make this work!! :) On Thu, Nov 4, 2021 at 1:15 AM ericvergnaud ***@***.***> wrote: > You sure you don’t want me to give it a try ? > I don’t have a PhD, so that might help ;-) > > > Le 3 nov. 2021 à 23:28, Terence Parr ***@***.***> a écrit : > > > > > > Anyway, i guess no 4.9.3 release as I can't figure it out. PhDs aren't > as useful as they used to be I guess haha > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub < > #3301 (comment)>, or > unsubscribe < > https://github.com/notifications/unsubscribe-auth/AAZNQJCGZ6ZZJEM2AQYTBADUKHAQTANCNFSM5FY2DH4Q > >. > > > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#3301 (comment)>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AABLUWOYP7BSKQ75FVLCRQDUKI6J5ANCNFSM5FY2DH4Q> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- Dictation in use. Please excuse homophones, malapropisms, and nonsense. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3301 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZNQJFV7HG3YHYYAUM6L53UKK2Y3ANCNFSM5FY2DH4Q>.

ericvergnaud · 2021-11-05T08:45:59Z

Hey, so from Sonatype support: "Unfortunately, publishers can't actually manage permissions their own on OSSRH. You'll have to create a Publishing Support issue in the OSSRH JIRA, and we can assist you with managing permissions. See the bottom section of this document for details: https://central.sonatype.org/faq/get-support/ <https://central.sonatype.org/faq/get-support/> " You need to visit the above page, at the bottom there is section for "Publishing support" and s paragraph "You need to add or remove users…" My sonatype user name is: ericvergnaud, email ***@***.*** ***@***.***> Do not forget to check the "Modify publishing permissions?" radio button Cheers

…

Le 4 nov. 2021 à 19:12, Eric Vergnaud ***@***.***> a écrit : Let me check that > Le 4 nov. 2021 à 17:51, Terence Parr ***@***.*** ***@***.***>> a écrit : > > > Sure! Tell me how to give you sonatype permissions! A real programmer like > you might be able to make this work!! :) > > On Thu, Nov 4, 2021 at 1:15 AM ericvergnaud ***@***.***> > wrote: > > > You sure you don’t want me to give it a try ? > > I don’t have a PhD, so that might help ;-) > > > > > Le 3 nov. 2021 à 23:28, Terence Parr ***@***.***> a écrit : > > > > > > > > > Anyway, i guess no 4.9.3 release as I can't figure it out. PhDs aren't > > as useful as they used to be I guess haha > > > > > > — > > > You are receiving this because you were mentioned. > > > Reply to this email directly, view it on GitHub < > > #3301 (comment) <#3301 (comment)>>, or > > unsubscribe < > > https://github.com/notifications/unsubscribe-auth/AAZNQJCGZ6ZZJEM2AQYTBADUKHAQTANCNFSM5FY2DH4Q <https://github.com/notifications/unsubscribe-auth/AAZNQJCGZ6ZZJEM2AQYTBADUKHAQTANCNFSM5FY2DH4Q> > > >. > > > > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub > > <#3301 (comment) <#3301 (comment)>>, or > > unsubscribe > > <https://github.com/notifications/unsubscribe-auth/AABLUWOYP7BSKQ75FVLCRQDUKI6J5ANCNFSM5FY2DH4Q <https://github.com/notifications/unsubscribe-auth/AABLUWOYP7BSKQ75FVLCRQDUKI6J5ANCNFSM5FY2DH4Q>> > > . > > Triage notifications on the go with GitHub Mobile for iOS > > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>> > > or Android > > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>>. > > > > > -- > Dictation in use. Please excuse homophones, malapropisms, and nonsense. > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub <#3301 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZNQJFV7HG3YHYYAUM6L53UKK2Y3ANCNFSM5FY2DH4Q>. >

parrt · 2021-11-06T18:48:48Z

I am rerunning scripts/github_release_notes.py and updating the release notes draft: https://github.com/antlr/antlr4/releases/edit/untagged-1690fce37cd84949ddcb

Ah. it looks like you're done so I just published it: https://github.com/antlr/antlr4/releases/tag/4.9.3

ericvergnaud · 2021-11-06T18:50:48Z

Missing a few runtimes to publish, check my last email

parrt · 2021-11-06T18:51:18Z

For C++ I think we just have to run source zip thing and pushed to the website download area. The others are all published in another way.

ericvergnaud · 2021-11-06T18:58:05Z

That’s already done

…

Le 6 nov. 2021 à 19:51, Terence Parr ***@***.***> a écrit : For C++ I think we just have to run source zip thing and pushed to the website download area. The others are all published in another way. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3301 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZNQJGZN5LIIP7FZJFRK2TUKWBMDANCNFSM5FY2DH4Q>.

parrt · 2021-11-06T18:58:58Z

You're the king! You should have the pleasure of hitting the close button on this issue!

ericvergnaud · 2021-11-06T19:05:41Z

Just need you to publish Dart, and I'll sure click!

parrt · 2021-11-06T19:18:23Z

Done! https://pub.dev/packages/antlr4/versions/4.9.3

ericvergnaud · 2021-11-06T19:18:42Z

Hooray !

parrt · 2021-11-06T19:19:23Z

thanks everyone!!!!

parrt · 2021-11-06T19:23:34Z

@bjansen a plugin release would be great, if you have time!

parrt added this to the 4.9.3 milestone Oct 11, 2021

This was referenced Oct 11, 2021

Arrays are not classes in Swift #3099

Merged

Swift InterpreterDataReader and deserialize fixes #3098

Merged

Fix Swift runtime ANTLRInputStream that can’t read Unicode scalars #3025

Merged

Silence Swift compiler warnings in Swift runtime #3026

Merged

ericvergnaud closed this as completed Nov 6, 2021

parrt mentioned this issue Dec 28, 2021

Add Support For Swift Package Manager #3132

Merged

Preparing for 4.9.3 release #3301

Preparing for 4.9.3 release #3301

Comments

parrt commented Oct 11, 2021

KvanTTT commented Oct 11, 2021

parrt commented Oct 11, 2021

hanjoes commented Oct 11, 2021

parrt commented Oct 11, 2021

lingyv-li commented Oct 11, 2021

ericvergnaud commented Oct 12, 2021

mike-lischke commented Oct 12, 2021 • edited Loading

parrt commented Oct 14, 2021

parrt commented Oct 14, 2021 • edited Loading

parrt commented Oct 14, 2021

parrt commented Oct 14, 2021

ericvergnaud commented Oct 14, 2021 via email

lambersond commented Oct 14, 2021

mike-lischke commented Oct 15, 2021

marcospassos commented Oct 15, 2021

KvanTTT commented Oct 17, 2021 • edited Loading

marcospassos commented Oct 18, 2021

ericvergnaud commented Oct 20, 2021 • edited Loading

parrt commented Oct 22, 2021

kaby76 commented Oct 22, 2021

parrt commented Oct 22, 2021

parrt commented Oct 24, 2021

parrt commented Oct 27, 2021

kaby76 commented Oct 27, 2021 • edited Loading

kaby76 commented Oct 28, 2021

ericvergnaud commented Oct 31, 2021 via email

parrt commented Oct 31, 2021

ericvergnaud commented Oct 31, 2021 via email

parrt commented Oct 31, 2021

ericvergnaud commented Oct 31, 2021 via email

parrt commented Nov 1, 2021

parrt commented Nov 1, 2021

parrt commented Nov 3, 2021

parrt commented Nov 3, 2021

parrt commented Nov 3, 2021 • edited Loading

parrt commented Nov 3, 2021 • edited Loading

parrt commented Nov 3, 2021

parrt commented Nov 3, 2021

ericvergnaud commented Nov 4, 2021 via email

parrt commented Nov 4, 2021 via email

hanjoes commented Nov 4, 2021

ericvergnaud commented Nov 4, 2021 via email

ericvergnaud commented Nov 5, 2021 via email

parrt commented Nov 6, 2021 • edited Loading

ericvergnaud commented Nov 6, 2021

parrt commented Nov 6, 2021

ericvergnaud commented Nov 6, 2021 via email

parrt commented Nov 6, 2021

ericvergnaud commented Nov 6, 2021

parrt commented Nov 6, 2021

ericvergnaud commented Nov 6, 2021

parrt commented Nov 6, 2021

parrt commented Nov 6, 2021

mike-lischke commented Oct 12, 2021 •

edited

Loading

parrt commented Oct 14, 2021 •

edited

Loading

KvanTTT commented Oct 17, 2021 •

edited

Loading

ericvergnaud commented Oct 20, 2021 •

edited

Loading

kaby76 commented Oct 27, 2021 •

edited

Loading

parrt commented Nov 3, 2021 •

edited

Loading

parrt commented Nov 3, 2021 •

edited

Loading

parrt commented Nov 6, 2021 •

edited

Loading