perf: Add default implementation for Visit in ParseTreeVisitor. (#3569)

* perf: Add default implementation for Visit in ParseTreeVisitor. Reference: https://github.com/antlr/antlr4/blob/ad29539cd2e94b2599e0281515f6cbb420d29f38/runtime/Java/src/org/antlr/v4/runtime/tree/AbstractParseTreeVisitor.java#L18 * doc: add contributor
antlr · Mar 7, 2022 · c693010 · c693010
1 parent 219ab7e
commit c693010
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/contributors.txt b/contributors.txt
@@ -326,3 +326,4 @@ YYYY/MM/DD, github id, Full name, email
 2021/12/16, Ketler13, Oleksandr Martyshchenko, [email protected]
 2021/12/25, Tinker1024, Tinker1024, [email protected]
 2021/12/31, Biswa96, Biswapriyo Nath, [email protected]
+2022/03/07, chenquan, chenquan, [email protected]
diff --git a/runtime/Go/antlr/tree.go b/runtime/Go/antlr/tree.go
@@ -64,7 +64,7 @@ type BaseParseTreeVisitor struct{}
 
 var _ ParseTreeVisitor = &BaseParseTreeVisitor{}
 
-func (v *BaseParseTreeVisitor) Visit(tree ParseTree) interface{}            { return nil }
+func (v *BaseParseTreeVisitor) Visit(tree ParseTree) interface{}            { return tree.Accept(v) }
 func (v *BaseParseTreeVisitor) VisitChildren(node RuleNode) interface{}     { return nil }
 func (v *BaseParseTreeVisitor) VisitTerminal(node TerminalNode) interface{} { return nil }
 func (v *BaseParseTreeVisitor) VisitErrorNode(node ErrorNode) interface{}   { return nil }