Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Password Length #191

Closed
bailejl opened this issue Feb 17, 2019 · 5 comments
Closed

Configurable Password Length #191

bailejl opened this issue Feb 17, 2019 · 5 comments
Assignees

Comments

@bailejl
Copy link

bailejl commented Feb 17, 2019

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [X] feature request

OS and Version?

All

Versions

N/A

Repro steps

  1. Go to register
  2. Add password ( it is hardcoded to a minimum and maximum length)

The log given by the failure

N/A

Desired functionality

Pass in a minimum and maximum password length

Mention any other details that might be useful

@AnthonyNahas
Copy link
Owner

@bailejl thanks for opening this issue.

For the password strength feature I am using my angular material extension password strength that supports different customization like mix max length and many other (see more)

Do you think for ngx-auth-firebaseui a min max password length inputs would be ok ? Or do u prefer to support all input and options that the password strength library supports ?

@bailejl
Copy link
Author

bailejl commented Mar 1, 2019

@AnthonyNahas From my point of view, password are weak and becoming weaker. So, the standard for a good password is going to change over time. Therefore, I recommend allowing implementors as much control as possible.

@madalinignisca
Copy link
Contributor

I vote for prefer to support all input and options that the password strength library supports

@AnthonyNahas AnthonyNahas self-assigned this Jul 3, 2019
@AnthonyNahas
Copy link
Owner

@madalinignisca I will do that 👍

@AnthonyNahas
Copy link
Owner

I've just published a new version of the library which supports now this requested feature.

The API of the @angular-material-extensions/password-strength has been integrated in the ngx-auth-firebaseui

Bildschirmfoto 2019-07-07 um 22 23 42

Bildschirmfoto 2019-07-07 um 22 24 12

here is the demo link: https://ngx-auth-firebaseui.firebaseapp.com/examples/password-strength

cheers and thank you all for contributing🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants