Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with password field #219

Closed
kuncevic opened this issue Apr 9, 2019 · 3 comments
Closed

Issues with password field #219

kuncevic opened this issue Apr 9, 2019 · 3 comments
Assignees

Comments

@kuncevic
Copy link

kuncevic commented Apr 9, 2019

- [ ] bug report -> please search issues before submitting
- [ x] feature request

Hi @AnthonyNahas thanks for a great library. There is some issues related to password field and password strength indicator that affects the overall experience of registering a new user. Currently it is really hard for an average user to get through the password field on registration tab.

Here is the detailed list:

a) It is does not allow to configure password strength.
b) The password strength indicator is always red color unless you put all the magic required characters which is really hard to figure out for average users.
c) Password length showed N/25 length so some think they really have to put 25 character password
d) Password field allow to type more than maximum allowed characters
e) Password strength has only two color states - red(accent) and blue(primary) so the default password complexity make it hard for users to get from red to blue indicator which make average users think they doing something wrong.

Repro steps

Navigate to https://ngx-auth-firebaseui.firebaseapp.com/home
Type more then 25 letters in the password field

Apr-10-2019 07-07-23

Desired functionality

Allow password strength to be configurable. (#191)
Do not allow to type more than maximum allowed characters.
Add intermediate state (e.g yellow) to password indicator.

Other info:

Currently as work around to make things simpler for new registrants I am disabling the mat-password-strength and mat-hint through css

mat-password-strength {
  display: none;
}
mat-hint {
  display: none;
}

If you have any questions or want me to provide any more details please let me know.

@AnthonyNahas
Copy link
Owner

I've just published a new version of the library which supports now this requested feature.

The API of the @angular-material-extensions/password-strength has been integrated in the ngx-auth-firebaseui

Bildschirmfoto 2019-07-07 um 22 23 42

Bildschirmfoto 2019-07-07 um 22 24 12

here is the demo link: https://ngx-auth-firebaseui.firebaseapp.com/examples/password-strength

cheers and thank you for contributing🍻

@crunck78
Copy link
Contributor

Hi Anthony. Thanks as well for this awsome lib. Is there a way to enable Password Strength for the standalone registration component?

@AnthonyNahas
Copy link
Owner

@crunck78 may you open a github ticket for that?

Thank you <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants