fix(object): the return type of objectMap should be the return type o… #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f callback function.
antfu
approved these changes
Jun 25, 2024
nandordudas
reviewed
Jun 25, 2024
| @@ -29,12 +29,12 @@ import type { DeepMerge } from './types' | |||
| * // { b: 2 } | |||
| * ``` | |||
| */ | |||
| export function objectMap<K extends string, V, NK = K, NV = V>(obj: Record<K, V>, fn: (key: K, value: V) => [NK, NV] | undefined): Record<K, V> { | |||
| export function objectMap<K extends string, V, NK extends string | number | symbol = K, NV = V>(obj: Record<K, V>, fn: (key: K, value: V) => [NK, NV] | undefined): Record<NK, NV> { | |||
There was a problem hiding this comment.
Just for curiosity, what do you think using of PropertyKey instead of string | number | symbol?
There was a problem hiding this comment.
Just for curiosity, what do you think using of
PropertyKeyinstead ofstring | number | symbol?
This idea of yours is better I think. I use string | number | symbol just because that's what VSCode suggests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It fixed the return type issue of
objectMap.Before:
After:
Linked Issues
Fixes #45
Additional context
I have to assert the type of return value because it cannot be compatible with
{ [k: string]: NV; }andRecord<NK, NV>and I have no idea how to fix it.